Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Deps: update JRuby to 9.2.18.0 #12791

Merged
merged 3 commits into from
Jun 9, 2021
Merged

Deps: update JRuby to 9.2.18.0 #12791

merged 3 commits into from
Jun 9, 2021

Conversation

kares
Copy link
Contributor

@kares kares commented Mar 31, 2021

Version bump of JRuby.

Release notes

Includes upstream fixes for ARM64 support.

What does this PR do?

Dependency update, release notes (since 9.2.16.0):
https://www.jruby.org/2021/03/29/jruby-9-2-17-0.html
https://www.jruby.org/2021/06/08/jruby-9-2-18-0.html

JRuby 9.2.18.0 include JNR fixes for ARM64: jnr/jnr-ffi#240 jnr/jnr-posix#165

Checklist

Author's Checklist

  • a potential blocker due LS' reuse of vendor/jruby/bin/jruby e.g. from bin/logstash-plugin
    (present in 9.2.17.0 but resolved in 9.2.18.0)
  • another suspicious issue with String#split

Related issues

#12077 (unfortunately the auto-load fixes were not backported to RGs 3.1)

Copy link
Member

@yaauie yaauie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks fine, but I would personally rather wait for 9.2.18.0 which will include the resolution for jruby/jruby#6638 WRT spaces in $JAVA_HOME

@kares kares changed the title Deps: update JRuby to 9.2.17.0 Deps: update JRuby to 9.2.18.0 Jun 9, 2021
Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please backport to 7.x

@jsvd jsvd added the JRuby 9K label Jun 9, 2021
@kares kares merged commit ee6038a into elastic:master Jun 9, 2021
kares added a commit to kares/logstash that referenced this pull request Jun 9, 2021
+ Fix: a missing require in bootstrap

(cherry picked from commit ee6038a)
@kares kares added the v7.14.0 label Jun 9, 2021
kares added a commit that referenced this pull request Jun 10, 2021
Backport PR #12791 to 7.x branch. Original message:

Version bump of JRuby.

+ Fix: a missing require in bootstrap

(cherry picked from commit ee6038a)
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants