Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

bump lock file for 8.16 #16776

Merged
merged 2 commits into from
Dec 11, 2024
Merged

bump lock file for 8.16 #16776

merged 2 commits into from
Dec 11, 2024

Conversation

github-actions[bot]
Copy link
Contributor

No description provided.

donoghuc
donoghuc previously approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@donoghuc donoghuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jar-dependencies explicit dependency addition looks to be the correct version (matches jruby default gem version). Plugins and other updates look complete.

@donoghuc donoghuc dismissed their stale review December 10, 2024 23:14

Missed an issue with ambigous gem spec

@donoghuc
Copy link
Member

Looks like this branch has the ambiguous date gem issue:


+WARN: Unresolved or ambiguous specs during Gem::Specification.reset:
--
  | +      date (>= 0)
  | +      Available/installed versions of this gem:
  | +      - 3.3.4
  | +      - 3.3.3

I think we need #16755 in this branch now.

@kaisecheng
Copy link
Contributor

date needs to be 3.3.3

@jsvd jsvd force-pushed the update_lock_1733849737 branch from 84d6583 to 3aaa1a5 Compare December 11, 2024 13:20
kaisecheng
kaisecheng approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@kaisecheng kaisecheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

History

@jsvd jsvd merged commit 2e7b1fe into 8.16 Dec 11, 2024
6 checks passed
@jsvd jsvd deleted the update_lock_1733849737 branch December 11, 2024 15:52
@karenzone karenzone mentioned this pull request Dec 13, 2024
Open
7 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kaisecheng kaisecheng kaisecheng approved these changes

@donoghuc donoghuc donoghuc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@donoghuc @kaisecheng @elasticmachine @jsvd @logstashmachine