Upgrade minitar to fix CVE-2016-10173 #8092
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Hi, thanks for the patch. Can you please perform step 2 of https://github.com/elasticsearch/logstash/blob/master/CONTRIBUTING.md#contribution-steps |
|
@suyograo Just signed it a second time. I guess the CLA status doesn't update here though. Also it looks like CI flaked but I can't rerun it without write perms on the repo. Could you kick that off for me? |
|
we now use minitar ~> 0.8.0, this can be closed https://github.com/elastic/logstash/blob/master/logstash-core/logstash-core.gemspec#L67 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed
rubyzipwas bumped to take care of a similar CVE, butminitaris still pinned to the old version.PR which fixed the issue: halostatue/minitar#16
Shipping a new version of
logstash-coreandlogstash-core-plugin-apiwould be super helpful as well.