-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[ESS][8.14] Documentation for Value list modal #5195
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Left a couple suggestions, hope they're helpful
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
I'll merge this once I've confirmed that the new copy is available in 8.14-BC5. |
Checked siem.dev server and confirmed that the new copy is available in the UI. |
* First draft * Fixing icons * Fixed refs to icons * Update docs/detections/value-list-exceptions.asciidoc * Update docs/detections/value-list-exceptions.asciidoc Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Update docs/detections/value-list-exceptions.asciidoc Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> --------- Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> (cherry picked from commit 3407651)
#5232) * First draft * Fixing icons * Fixed refs to icons * Update docs/detections/value-list-exceptions.asciidoc * Update docs/detections/value-list-exceptions.asciidoc Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Update docs/detections/value-list-exceptions.asciidoc Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> --------- Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> (cherry picked from commit 3407651) Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Contributes to #5052
Main value list docs that need to be reviewed:
I also refreshed related docs and screenshots to account for the renamed Import value list button (the new name is Manage value lists). These pages would benefit from a quick spot check:
Twin Serverless PR: https://github.com/elastic/staging-serverless-security-docs/pull/322