Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Serverless][8.18] EQL Sequence alert suppression #6291

Merged
merged 22 commits into from
Dec 23, 2024

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Dec 10, 2024

Fixes #5886

ESS

  • Alert suppression - Made the following changes:
    • Removed the second bullet in the requirements note at the start of the page since alert suppression for EQL rules will be GA in 8.18.
    • Updated the note after step 1 that explains how suppression fields with multiple values are handled. Added a third bullet for event correlation rules using sequence queries.
  • Create a detection rule | Create an event correlation rule - Removes the tech preview label from step 6, which lets users know that they can suppress alerts from this rule type.

Serverless

NOTE: Suppression for EQL rules in Serverless will go GA around the same time that 8.18 GAs. I'll open a separate PR to update the Serverless docs once that date approaches.

@nastasha-solomon nastasha-solomon added Feature: Rules Team: Detection Engine Priority: High Issues that are time-sensitive and/or are of high customer importance Effort: Medium Issues that take moderate but not substantial time to complete v8.17.0 v8.18.0 labels Dec 10, 2024
@nastasha-solomon nastasha-solomon self-assigned this Dec 10, 2024
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@natasha-moore-elastic
Copy link
Contributor

Per this comment, this feature didn't make it into 8.17.

@nastasha-solomon nastasha-solomon marked this pull request as ready for review December 16, 2024 23:39
@nastasha-solomon nastasha-solomon requested a review from a team as a code owner December 16, 2024 23:39
@dhurley14 dhurley14 changed the title [Serverless][8.17] EQL Sequence alert suppression [Serverless][8.18] EQL Sequence alert suppression Dec 17, 2024
Copy link
Contributor

@dhurley14 dhurley14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one clarification. Looks great!

dhurley14
dhurley14 previously approved these changes Dec 19, 2024
jmikell821
jmikell821 previously approved these changes Dec 19, 2024
@nastasha-solomon nastasha-solomon requested a review from a team December 19, 2024 22:03
@benironside benironside merged commit ed389ce into main Dec 23, 2024
3 checks passed
mergify bot pushed a commit that referenced this pull request Dec 23, 2024
* First draft

* draft 1

* Update docs/detections/alert-suppression.asciidoc

* fix it?

* Moves info

* updating ref

* Update docs/detections/building-block-rule.asciidoc

* Update docs/serverless/rules/building-block-rule.asciidoc

* Removing empty lines

* Removes tech preview label for 8.18

* updates note about reqs

* Re-adds +

* Fixes Serverless note

* Fixes numebring

(cherry picked from commit ed389ce)

# Conflicts:
#	docs/serverless/alerts/alert-suppression.asciidoc
benironside pushed a commit that referenced this pull request Dec 27, 2024
…) (#6381)

* [Serverless][8.18] EQL Sequence alert suppression  (#6291)

* First draft

* draft 1

* Update docs/detections/alert-suppression.asciidoc

* fix it?

* Moves info

* updating ref

* Update docs/detections/building-block-rule.asciidoc

* Update docs/serverless/rules/building-block-rule.asciidoc

* Removing empty lines

* Removes tech preview label for 8.18

* updates note about reqs

* Re-adds +

* Fixes Serverless note

* Fixes numebring

(cherry picked from commit ed389ce)

# Conflicts:
#	docs/serverless/alerts/alert-suppression.asciidoc

* Delete docs/serverless directory and its contents

---------

Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@nastasha-solomon nastasha-solomon deleted the issue-5886-alert-suppression-eql-seq branch January 31, 2025 20:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Effort: Medium Issues that take moderate but not substantial time to complete Feature: Rules Priority: High Issues that are time-sensitive and/or are of high customer importance Team: Detection Engine v8.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request][Serverless][ESS] EQL Sequence alert suppression
5 participants