Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Document ways to provide multiple Agent uninstall tokens #6300

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

natasha-moore-elastic
Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic commented Dec 12, 2024

@natasha-moore-elastic natasha-moore-elastic added enhancement New feature or request Team: EDR Workflows Formerly Defend Workflows, Onboarding and Lifecycle Management Feature: Elastic Defend Docset: Serverless Issues for Serverless Security v8.11.0 Docset: ESS Issues that apply to docs in the Stack release v8.12.0 v8.13.0 v8.14.0 v8.15.0 v8.17.0 8.16.1 labels Dec 12, 2024
@natasha-moore-elastic natasha-moore-elastic self-assigned this Dec 12, 2024
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@natasha-moore-elastic natasha-moore-elastic marked this pull request as ready for review December 12, 2024 13:47
@natasha-moore-elastic natasha-moore-elastic requested a review from a team as a code owner December 12, 2024 13:47
ferullo
ferullo previously approved these changes Dec 12, 2024
Copy link
Collaborator

@ferullo ferullo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

FWIW, one of the hashes is rendering in red. Maybe [source,shell] is not right?

image

@natasha-moore-elastic
Copy link
Contributor Author

natasha-moore-elastic commented Dec 13, 2024

LGTM, thanks!

FWIW, one of the hashes is rendering in red. Maybe [source,shell] is not right?

image

Hmm, the second code block is [source,txt], and the behavior is the same... I think this is just how our CSS works, it looks like anything inside a code block that starts with a digit is rendered in red – there are more examples of this on the Endpoint command reference page.

Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left a couple minor suggestions for your consideration

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
@natasha-moore-elastic natasha-moore-elastic merged commit 87e3acb into main Dec 17, 2024
3 checks passed
mergify bot pushed a commit that referenced this pull request Dec 17, 2024
* Document ways to provide multiple Agent uninstall tokens

* Apply suggestions from code review

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

---------

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
(cherry picked from commit 87e3acb)

# Conflicts:
#	docs/serverless/edr-install-config/agent-tamper-protection.asciidoc
#	docs/serverless/edr-install-config/uninstall-agent.asciidoc
mergify bot pushed a commit that referenced this pull request Dec 17, 2024
* Document ways to provide multiple Agent uninstall tokens

* Apply suggestions from code review

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

---------

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
(cherry picked from commit 87e3acb)

# Conflicts:
#	docs/serverless/edr-install-config/agent-tamper-protection.asciidoc
#	docs/serverless/edr-install-config/uninstall-agent.asciidoc
mergify bot pushed a commit that referenced this pull request Dec 17, 2024
* Document ways to provide multiple Agent uninstall tokens

* Apply suggestions from code review

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

---------

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
(cherry picked from commit 87e3acb)

# Conflicts:
#	docs/serverless/edr-install-config/agent-tamper-protection.asciidoc
#	docs/serverless/edr-install-config/uninstall-agent.asciidoc
mergify bot pushed a commit that referenced this pull request Dec 17, 2024
* Document ways to provide multiple Agent uninstall tokens

* Apply suggestions from code review

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

---------

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
(cherry picked from commit 87e3acb)

# Conflicts:
#	docs/getting-started/uninstall-agent.asciidoc
#	docs/serverless/edr-install-config/agent-tamper-protection.asciidoc
#	docs/serverless/edr-install-config/uninstall-agent.asciidoc
mergify bot pushed a commit that referenced this pull request Dec 17, 2024
* Document ways to provide multiple Agent uninstall tokens

* Apply suggestions from code review

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

---------

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
(cherry picked from commit 87e3acb)

# Conflicts:
#	docs/getting-started/uninstall-agent.asciidoc
#	docs/serverless/edr-install-config/agent-tamper-protection.asciidoc
#	docs/serverless/edr-install-config/uninstall-agent.asciidoc
mergify bot pushed a commit that referenced this pull request Dec 17, 2024
* Document ways to provide multiple Agent uninstall tokens

* Apply suggestions from code review

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

---------

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
(cherry picked from commit 87e3acb)

# Conflicts:
#	docs/getting-started/uninstall-agent.asciidoc
#	docs/serverless/edr-install-config/agent-tamper-protection.asciidoc
#	docs/serverless/edr-install-config/uninstall-agent.asciidoc
mergify bot pushed a commit that referenced this pull request Dec 17, 2024
* Document ways to provide multiple Agent uninstall tokens

* Apply suggestions from code review

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

---------

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
(cherry picked from commit 87e3acb)

# Conflicts:
#	docs/getting-started/uninstall-agent.asciidoc
#	docs/serverless/edr-install-config/agent-tamper-protection.asciidoc
#	docs/serverless/edr-install-config/uninstall-agent.asciidoc
mergify bot pushed a commit that referenced this pull request Dec 17, 2024
* Document ways to provide multiple Agent uninstall tokens

* Apply suggestions from code review

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

---------

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
(cherry picked from commit 87e3acb)

# Conflicts:
#	docs/getting-started/uninstall-agent.asciidoc
#	docs/serverless/edr-install-config/agent-tamper-protection.asciidoc
#	docs/serverless/edr-install-config/uninstall-agent.asciidoc
natasha-moore-elastic added a commit that referenced this pull request Dec 17, 2024
…ort #6300) (#6350)

* Document ways to provide multiple Agent uninstall tokens (#6300)

* Document ways to provide multiple Agent uninstall tokens

* Apply suggestions from code review

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

---------

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
(cherry picked from commit 87e3acb)

# Conflicts:
#	docs/serverless/edr-install-config/agent-tamper-protection.asciidoc
#	docs/serverless/edr-install-config/uninstall-agent.asciidoc

* Delete docs/serverless directory and its contents

---------

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
natasha-moore-elastic added a commit that referenced this pull request Dec 17, 2024
…port #6300) (#6351)

* Document ways to provide multiple Agent uninstall tokens (#6300)

* Document ways to provide multiple Agent uninstall tokens

* Apply suggestions from code review

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

---------

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
(cherry picked from commit 87e3acb)

# Conflicts:
#	docs/serverless/edr-install-config/agent-tamper-protection.asciidoc
#	docs/serverless/edr-install-config/uninstall-agent.asciidoc

* Delete docs/serverless directory and its contents

---------

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
natasha-moore-elastic added a commit that referenced this pull request Dec 17, 2024
…port #6300) (#6352)

* Document ways to provide multiple Agent uninstall tokens (#6300)

* Document ways to provide multiple Agent uninstall tokens

* Apply suggestions from code review

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

---------

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
(cherry picked from commit 87e3acb)

# Conflicts:
#	docs/serverless/edr-install-config/agent-tamper-protection.asciidoc
#	docs/serverless/edr-install-config/uninstall-agent.asciidoc

* Delete docs/serverless directory and its contents

---------

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
natasha-moore-elastic added a commit that referenced this pull request Dec 17, 2024
…port #6300) (#6353)

* Document ways to provide multiple Agent uninstall tokens (#6300)

* Document ways to provide multiple Agent uninstall tokens

* Apply suggestions from code review

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

---------

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
(cherry picked from commit 87e3acb)

# Conflicts:
#	docs/getting-started/uninstall-agent.asciidoc
#	docs/serverless/edr-install-config/agent-tamper-protection.asciidoc
#	docs/serverless/edr-install-config/uninstall-agent.asciidoc

* Delete docs/serverless directory and its contents

* Resolves conflict

---------

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: natasha-moore-elastic <natasha.moore@elastic.co>
natasha-moore-elastic added a commit that referenced this pull request Dec 17, 2024
…port #6300) (#6354)

* Document ways to provide multiple Agent uninstall tokens (#6300)

* Document ways to provide multiple Agent uninstall tokens

* Apply suggestions from code review

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

---------

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
(cherry picked from commit 87e3acb)

# Conflicts:
#	docs/getting-started/uninstall-agent.asciidoc
#	docs/serverless/edr-install-config/agent-tamper-protection.asciidoc
#	docs/serverless/edr-install-config/uninstall-agent.asciidoc

* Delete docs/serverless directory and its contents

* Resolves conflict

---------

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: natasha-moore-elastic <natasha.moore@elastic.co>
natasha-moore-elastic added a commit that referenced this pull request Dec 17, 2024
…port #6300) (#6355)

* Document ways to provide multiple Agent uninstall tokens (#6300)

* Document ways to provide multiple Agent uninstall tokens

* Apply suggestions from code review

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

---------

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
(cherry picked from commit 87e3acb)

# Conflicts:
#	docs/getting-started/uninstall-agent.asciidoc
#	docs/serverless/edr-install-config/agent-tamper-protection.asciidoc
#	docs/serverless/edr-install-config/uninstall-agent.asciidoc

* Delete docs/serverless directory and its contents

* Resolves conflict

---------

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: natasha-moore-elastic <natasha.moore@elastic.co>
natasha-moore-elastic added a commit that referenced this pull request Dec 17, 2024
…port #6300) (#6356)

* Document ways to provide multiple Agent uninstall tokens (#6300)

* Document ways to provide multiple Agent uninstall tokens

* Apply suggestions from code review

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

---------

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
(cherry picked from commit 87e3acb)

# Conflicts:
#	docs/getting-started/uninstall-agent.asciidoc
#	docs/serverless/edr-install-config/agent-tamper-protection.asciidoc
#	docs/serverless/edr-install-config/uninstall-agent.asciidoc

* Delete docs/serverless directory and its contents

* Resolves conflict

---------

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: natasha-moore-elastic <natasha.moore@elastic.co>
natasha-moore-elastic added a commit that referenced this pull request Dec 17, 2024
…port #6300) (#6357)

* Document ways to provide multiple Agent uninstall tokens (#6300)

* Document ways to provide multiple Agent uninstall tokens

* Apply suggestions from code review

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

---------

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
(cherry picked from commit 87e3acb)

# Conflicts:
#	docs/getting-started/uninstall-agent.asciidoc
#	docs/serverless/edr-install-config/agent-tamper-protection.asciidoc
#	docs/serverless/edr-install-config/uninstall-agent.asciidoc

* Delete docs/serverless directory and its contents

* Resolves conflict

---------

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: natasha-moore-elastic <natasha.moore@elastic.co>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Docset: ESS Issues that apply to docs in the Stack release Docset: Serverless Issues for Serverless Security enhancement New feature or request Feature: Elastic Defend Team: EDR Workflows Formerly Defend Workflows, Onboarding and Lifecycle Management v8.11.0 v8.12.0 v8.13.0 v8.14.0 v8.15.0 v8.16.0 v8.17.0 v8.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document ways to provide multiple tamper protection --uninstall-token values
3 participants