-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
DstHostIs returns with port #301
Comments
Hi,
Thanks for reporting it.
Care to send a PR?
Unfortunately I don't have time to fix it now.
…On Tue, Jul 17, 2018 at 1:55 PM Berkant ***@***.***> wrote:
The example in readme.md won't work. It returns with the port regardless
it is http or https.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#301>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAP4onGCP8YxVNSidW6H_ovybDTrU8ZMks5uHcK4gaJpZM4VSoFw>
.
|
@elazarl I think that DstHostIs should not return a port. What do you think about it? |
Sounds like a bug. It probably should be the host with the port.
Do send a PR.
…On Tue, Jul 24, 2018 at 5:30 PM Berkant ***@***.***> wrote:
@elazarl <https://github.com/elazarl> I think that DstHostIs should not
return a port. What do you think about it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#301 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAP4otsZrg46W4C0DQ3eQcVMvYSCRdB1ks5uJy-ZgaJpZM4VSoFw>
.
|
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
The example in readme.md won't work. It returns with the port regardless it is http or https.
The text was updated successfully, but these errors were encountered: