Add a few more protections if current name doesn't resolve anymore. #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
|
Line 124 has this original problem....especially if $param happens to be empty |
|
Yes, but on Line 120, if $param is empty it immediately returns. |
|
`Create/Update database for config "/etc/awstats/awstats.site.conf" by AWStats version 7.7 (build 20180105) From data in log file "/usr/local/awstats/tools/logresolvemerge.pl /var/log/apache2/log1.log /var/log/apache2/log2.log |"... Bad arg length for Socket::inet_ntoa, length is 0, should be 4 at /usr/local/awstats/wwwroot/cgi-bin/plugins/geoip2.pm line 124, line 13483. Phase 1 : First bypass old records, searching new record... Searching new records from beginning of log file... Phase 2 : Now process new records (Flush history on disk after 20000 hosts)...` |
manuelm
added a commit
to manuelm/awstats
that referenced
this pull request
Apr 26, 2019
* Correctly convert dns names to ip4 and ip6 address using getaddrinfo (fixes eldy#120, eldy#121, obsoletes eldy#115) * Only lookup if the IP is of type public (fixes eldy#122) and catch further lookup errors (obsoletes eldy#123) * Store and display the GeoIP City output HTML escaped (fixes eldy#127) * Code to perform and cache the actual lookup is consolidated * General code improvement and readability
|
Hope to have this fixed by #131 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at previous reports, if a name was no longer resolving either because the DNS entry was no longer there, or a temporary failure in DNS resolution, the current code would fail at the
$address = inet_ntoa(inet_aton($param));line. Added some logic that if theinet_atonreturned nothing, then skip this entry and keep going.