-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add apparmor profile #8635
Comments
I can definitely get this feature implemented. Quick Q. What is this doing?
Do we need this line for the base AppArmor profile supplied by electron-builder? I'll also create a configuration param |
Sorry, I put some concrete names instead of placeholder
So, if the executable is e.g. Also note parentheses around path "/opt//" - is used without parentheses then spaces (and maybe some other chars) has to be escaped. Param |
This won't help distributing by AppImage though right? Any idea what the path forward for AppImage is? |
@shadow-light might be idea to voice that concern here: https://bugs.launchpad.net/ubuntu/+source/apparmor/+bug/2046844 |
@shadow-light, unfortunately, due to the ephemeral nature of AppImage's being executable (and updateable) from any location presents difficulty in creating (and removal) of the I'll only be able to support this on FPM-based targets |
This was implemented for FPM-based distributions in electron-builder v26.0.0-alpha.6 Can you please give it a test and report back if it also resolves the issue for you? (particularly helpful for confirmation since we're in an alpha release version) |
👍 Works well on Ubuntu 24 (installs AppArmor profile) and Ubuntu 22 (does not install AppArmor profile) too. |
AFAIK this is not fixed for AppImage right? |
@Sytten indeed, as mentioned here: #8635 (comment) |
In particular, * Electron 34 is needed to fix the Flatpak file picker issue - "Fixed file chooser dialogs for flaptak applications. #44681" electron/electron#44681 * Electron builder 26 is needed for the FPM app armour profiles electron-userland/electron-builder#8635 (comment)
In particular, * Electron 34 is needed to fix the Flatpak file picker issue - "Fixed file chooser dialogs for flaptak applications. #44681" electron/electron#44681 * Electron builder 26 is needed for the FPM app armour profiles electron-userland/electron-builder#8635 (comment)
Ubuntu 24 installation requires AppArmor profile to be configured for the app, see
Solution is to detect OS with AppArmor and create a file in
/etc/apparmor.d/<exe-name>
:Note: remove this file when the app is uninstalled.
See also:
after-install.tpl
checking AppArmor and installation.The text was updated successfully, but these errors were encountered: