chore: avoid crash while notification removal (#43061)

* avoid crash of operation on an invalid entry while erase set iterator. Co-authored-by: bill.shen <shenyb32768@gmail.com> * fix notification removal crash due to the nullptr presenter Co-authored-by: bill.shen <shenyb32768@gmail.com> --------- Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: bill.shen <shenyb32768@gmail.com>
electron · Jul 26, 2024 · b6e19c5 · b6e19c5
1 parent 871136b
commit b6e19c5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/shell/browser/notifications/notification.cc b/shell/browser/notifications/notification.cc
@@ -46,7 +46,9 @@ void Notification::NotificationFailed(const std::string& error) {
 void Notification::Remove() {}
 
 void Notification::Destroy() {
-  presenter()->RemoveNotification(this);
+  if (presenter()) {
+    presenter()->RemoveNotification(this);
+  }
 }
 
 }  // namespace electron
diff --git a/shell/browser/notifications/notification_presenter.cc b/shell/browser/notifications/notification_presenter.cc
@@ -27,6 +27,11 @@ base::WeakPtr<Notification> NotificationPresenter::CreateNotification(
 }
 
 void NotificationPresenter::RemoveNotification(Notification* notification) {
+  auto it = notifications_.find(notification);
+  if (it == notifications_.end()) {
+    return;
+  }
+
   notifications_.erase(notification);
   delete notification;
 }