Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade to Chrome 40 #1002

Merged
merged 22 commits into from
Jan 28, 2015
Merged

Upgrade to Chrome 40 #1002

merged 22 commits into from
Jan 28, 2015

Conversation

zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Jan 13, 2015

Merge this after there is a stable release of Chrome 40.

@mark-hahn
Copy link

Will this fix the webview problem also? Is there an easy way for me to build atom using this so I can test the webview?

@anaisbetts
Copy link
Contributor

@zcbenz Can you git push all your submodules? libchromiumcontent is pinned to a commit that isn't up on GitHub atm

@zcbenz
Copy link
Contributor Author

zcbenz commented Jan 22, 2015

Chrome 40 becomes stable today, I'll finish this PR.

@mark-hahn The change I need to fix the <webivew> crash is not in Chrome40 yet, I'm afraid we have to wait until Chrome41, but I'll still have a try.

@zcbenz
Copy link
Contributor Author

zcbenz commented Jan 23, 2015

Latest nan is now using NODE_MODULE_VERSION to determine the V8 version to support, in order to be compatible with nan we need to pick a NODE_MODULE_VERSION value very carefully.

@zcbenz
Copy link
Contributor Author

zcbenz commented Jan 23, 2015

Currently blocked by compatibility with nan: nodejs/nan#226.

Some APIs deprecated by iojs is still in use.
@anaisbetts
Copy link
Contributor

Would it be worth it to forget about the io.js migration for this PR? It seems like it's going to bust a ton of native modules right now since it's super new. Or will Chrome 40's version of V8 bust them anyways, so who cares?

@zcbenz
Copy link
Contributor Author

zcbenz commented Jan 28, 2015

The problem is Atom uses lots of native modules and I have to make Atom work with Chrome 40. Anyway I have just uploaded a modified version of nan to work around it.

zcbenz added a commit that referenced this pull request Jan 28, 2015
@zcbenz zcbenz merged commit f829f2e into master Jan 28, 2015
@zcbenz zcbenz deleted the chrome40 branch January 28, 2015 01:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants