Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(template-webpack): only use node-loader if the .node files are in native_modules/ #2449

Conversation

malept
Copy link
Member

@malept malept commented Aug 16, 2021

Summarize your changes:

Apparently the asset relocator loader generates "fake" .node files which are actually JS files that point toward the relocated native modules in native_modules/. Since they're not actually native code, we can't have node-loader load them. To fix this, adjust the default test for the node-loader to only pick up .node modules in a native_modules folder. (This can be adjusted as necessary by the Electron app author).

@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #2449 (9f2ef5a) into master (5047f5b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2449   +/-   ##
=======================================
  Coverage   75.35%   75.35%           
=======================================
  Files          91       91           
  Lines        2353     2353           
  Branches      440      440           
=======================================
  Hits         1773     1773           
  Misses        472      472           
  Partials      108      108           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5047f5b...9f2ef5a. Read the comment docs.

@malept malept merged commit bd2526b into master Aug 16, 2021
@malept malept deleted the malept/fix/plugin-webpack/native-modules-node-loader-specificity branch August 16, 2021 22:21
alex-ketch added a commit to stencila/stencila that referenced this pull request Aug 31, 2021
alex-ketch added a commit to stencila/stencila that referenced this pull request Aug 31, 2021
alex-ketch added a commit to stencila/stencila that referenced this pull request Sep 1, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant