Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Dendrite returns improper error codes for unknown endpoints #2903

Closed
matrixbot opened this issue Nov 1, 2024 · 3 comments
Closed

Dendrite returns improper error codes for unknown endpoints #2903

matrixbot opened this issue Nov 1, 2024 · 3 comments
Labels
good first issue Good for newcomers O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Minor significance, cosmetic issues, low or no impact to users. spec-compliance Fix something that doesn't comply with the specs T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@matrixbot
Copy link
Collaborator

This issue was originally created by @clokep at matrix-org/dendrite#2903.

Dendrite returns improper responses for unknown endpoints per MSC3743, see matrix-org/complement#565 for tests I'm adding for this.

Dendrite is:

  • Returning a 404 instead of a 405 for an unknown methods on Client-Server APIs.
  • Returning a text response, instead of JSON, error on /media, /key, /federation and unknown prefixes.
@matrixbot matrixbot added good first issue Good for newcomers O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Minor significance, cosmetic issues, low or no impact to users. spec-compliance Fix something that doesn't comply with the specs T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. labels Nov 1, 2024
@matrixbot
Copy link
Collaborator Author

This comment was originally posted by @clokep at matrix-org/dendrite#2903 (comment).

Related: #2740

@matrixbot
Copy link
Collaborator Author

This comment was originally posted by @clokep at matrix-org/dendrite#2903 (comment).

Tests can probably be re-enabled at https://github.com/matrix-org/complement/blob/778409aa2237e4e2fddb54e3fcdeb4a21d77674d/tests/unknown_endpoints_test.go#L41 😄

@matrixbot
Copy link
Collaborator Author

This comment was originally posted by @clokep at matrix-org/dendrite#2903 (comment).

And I see you already did this at matrix-org/complement#630 🤦

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Minor significance, cosmetic issues, low or no impact to users. spec-compliance Fix something that doesn't comply with the specs T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matrixbot