Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

Dendrite returns improper error codes for unknown endpoints #2903

Closed
clokep opened this issue Dec 2, 2022 · 3 comments · Fixed by #3016
Closed

Dendrite returns improper error codes for unknown endpoints #2903

clokep opened this issue Dec 2, 2022 · 3 comments · Fixed by #3016
Labels
good first issue Want to help with Dendrite? These are the issues to start with! O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Minor significance, cosmetic issues, low or no impact to users. spec-compliance Fix something that doesn't comply with the specs T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@clokep
Copy link
Member

clokep commented Dec 2, 2022

Dendrite returns improper responses for unknown endpoints per MSC3743, see matrix-org/complement#565 for tests I'm adding for this.

Dendrite is:

  • Returning a 404 instead of a 405 for an unknown methods on Client-Server APIs.
  • Returning a text response, instead of JSON, error on /media, /key, /federation and unknown prefixes.
@clokep clokep added bug spec-compliance Fix something that doesn't comply with the specs labels Dec 2, 2022
@kegsay kegsay added T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. and removed bug labels Dec 5, 2022
@clokep
Copy link
Member Author

clokep commented Dec 6, 2022

Related: #2740

@kegsay kegsay added S-Tolerable Minor significance, cosmetic issues, low or no impact to users. O-Occasional Affects or can be seen by some users regularly or most users rarely labels Dec 8, 2022
@S7evinK S7evinK added the good first issue Want to help with Dendrite? These are the issues to start with! label Feb 17, 2023
S7evinK added a commit that referenced this issue Mar 16, 2023
@S7evinK
Make Dendrite spec compliant, fix #2903
59eaec4
@S7evinK S7evinK mentioned this issue Mar 16, 2023
Merged
S7evinK added a commit that referenced this issue Mar 17, 2023
@S7evinK
Preparations for removing BaseDendrite (#3016)
5579121 
Preparations to actually remove/replace `BaseDendrite`.
Quite a few changes:
- SyncAPI accepts an `fulltext.Indexer` interface (fulltext is removed
from `BaseDendrite`)
- Caches are removed from `BaseDendrite`
- Introduces a `Router` struct (likely to change)
  - also fixes #2903
- Introduces a `sqlutil.ConnectionManager`, which should remove
`base.DatabaseConnection` later on
- probably more
@clokep
Copy link
Member Author

clokep commented Mar 17, 2023

Tests can probably be re-enabled at https://github.com/matrix-org/complement/blob/778409aa2237e4e2fddb54e3fcdeb4a21d77674d/tests/unknown_endpoints_test.go#L41 😄

@clokep
Copy link
Member Author

clokep commented Mar 17, 2023

And I see you already did this at matrix-org/complement#630 🤦

@matrixbot matrixbot mentioned this issue Nov 1, 2024
Closed
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
good first issue Want to help with Dendrite? These are the issues to start with! O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Minor significance, cosmetic issues, low or no impact to users. spec-compliance Fix something that doesn't comply with the specs T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Preparations for removing BaseDendrite matrix-org/dendrite
3 participants
@clokep @S7evinK @kegsay