Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Redacting membership events should immediately reset the displayname & avatar of room members #443

Open
matrixbot opened this issue Jul 11, 2016 · 6 comments
Open

Redacting membership events should immediately reset the displayname & avatar of room members #443

matrixbot opened this issue Jul 11, 2016 · 6 comments
Assignees
@giomfo
Labels
P1 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Milestone
sprint2.2

Comments

@matrixbot
Copy link

Created by @ matthew:matrix.org.

This is useful for killing offensive avatars & nicks immediately; currently it gets cached until the next initial sync
@giomfo giomfo added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems P1 labels Jul 13, 2016
@giomfo giomfo added this to the sprint2.1 milestone Jul 13, 2016
@giomfo
Copy link
Member

giomfo commented Jul 13, 2016

The client must update the local room state on redaction event which concerned membership events.

@giomfo giomfo modified the milestones: sprint2.2, sprint2.1 Jul 15, 2016
giomfo added a commit to matrix-org/matrix-ios-sdk that referenced this issue Jul 15, 2016
@giomfo
Redacting membership events should immediately reset the displayname …
7af3872 
…& avatar of room members.

element-hq/element-ios#443

- MXEventTimeline: prepare state event redaction.
- MXRoom Notification break: rename "kMXRoomSyncWithLimitedTimelineNotification" with "kMXRoomDidFlushMessagesNotification"
giomfo added a commit to matrix-org/matrix-ios-sdk that referenced this issue Jul 17, 2016
@giomfo
Redacting membership events should immediately reset the displayname …
ae312a3 
…& avatar of room members.

element-hq/element-ios#443

- Fix: The redacted state event was ignored in room state handling
- Add FIXME related to the blocker issue on server side SYN-724 ("prev_content is totally pruned by the server on redacted membership event").
@giomfo
Copy link
Member

giomfo commented Jul 17, 2016

Blocked by SYN-724 (prev_content is totally pruned by the server on redacted membership event).

@ylecollen
Copy link

What i've done on the android client
https://github.com/matrix-org/matrix-android-sdk/blob/develop/matrix-sdk/src/main/java/org/matrix/androidsdk/data/EventTimeline.java#L625

https://github.com/matrix-org/matrix-android-sdk/blob/develop/matrix-sdk/src/main/java/org/matrix/androidsdk/data/EventTimeline.java#L1306

When a membership event is redacted, the client always requests the up-to date-roomState to the server and forces the room history reload (it is already done on the IOS client) but it also refresh the members list and the room settings.
Indeed, the redaction must not update the live state because it might not concern it.

eg with this room history

... older messages
message_1 : A renames this room to Name1
... some other messages
message_2 : A renames this room to Name2
... other messages

If message_1 is redacted, the room name must not be cleared because it has been updated by message_2.

giomfo added a commit to matrix-org/matrix-ios-sdk that referenced this issue Aug 11, 2016
@giomfo
Redacting membership events should immediately reset the displayname …
a8b97fb 
…& avatar of room members.

element-hq/element-ios#443

- remove FIXME (the blocker issue SYN-724 has been fixed on server side).
@giomfo giomfo self-assigned this Aug 11, 2016
giomfo added a commit to matrix-org/matrix-ios-kit that referenced this issue Aug 11, 2016
@giomfo
Redacting membership events should immediately reset the displayname …
1b9bd99 
…& avatar of room members

element-hq/element-ios#443

- Fix: last bubble is removed by mistake on membership redaction
giomfo added a commit to matrix-org/matrix-ios-kit that referenced this issue Aug 12, 2016
@giomfo
Redacting membership events should immediately reset the displayname …
21754a0 
…& avatar of room members.

element-hq/element-ios#443

Refresh the display of the room settings and the room member details on state event redaction
giomfo added a commit that referenced this issue Aug 12, 2016
@giomfo
Redacting membership events should immediately reset the displayname …
5009263 
…& avatar of room members.

#443

Refresh Room members list on state event redaction
giomfo added a commit to matrix-org/matrix-ios-kit that referenced this issue Aug 12, 2016
@giomfo
Redacting membership events should immediately reset the displayname …
1a53111 
…& avatar of room members

element-hq/element-ios#443

code cleaning
@giomfo giomfo mentioned this issue Aug 12, 2016
Merged
giomfo added a commit to matrix-org/matrix-ios-sdk that referenced this issue Aug 12, 2016
@giomfo
Redacting membership events should immediately reset the displayname …
e1158a4 
…& avatar of room members.

element-hq/element-ios#443

Fix Manu's comments (#118).
giomfo added a commit to matrix-org/matrix-ios-kit that referenced this issue Aug 12, 2016
@giomfo
Redacting membership events should immediately reset the displayname …
6c54025 
…& avatar of room members.

element-hq/element-ios#443

Fix Manu's comments (matrix-org/matrix-ios-sdk#118)
giomfo added a commit that referenced this issue Aug 12, 2016
@giomfo
Redacting membership events should immediately reset the displayname …
e11b365 
…& avatar of room members.

#443

Fix Manu's comments (matrix-org/matrix-ios-sdk#118)
@giomfo giomfo closed this as completed Aug 12, 2016
@giomfo giomfo removed the X-Blocked label Aug 12, 2016
@manuroe manuroe mentioned this issue Mar 27, 2018
Closed
@manuroe
Copy link
Member

manuroe commented Mar 27, 2018

Reopened because of #1823.

It needs a better implementation. Homeservers could help clients by providing the prev_event_id that corresponds to the prev_content set it a state event.
Thus, clients will be able to able to prune prev_content locally.

@manuroe manuroe reopened this Mar 27, 2018
@manuroe
Copy link
Member

manuroe commented Mar 27, 2018

Note: Riot-iOS was the only client to support correctly the back pagination in this case.

@manuroe manuroe mentioned this issue Mar 1, 2022
Open
@manuroe
Copy link
Member

manuroe commented Mar 27, 2018

Need https://github.com/matrix-org/matrix-doc/issues/1167 to handle the issue without breaking HSes.

@manuroe manuroe mentioned this issue Mar 27, 2018
Closed
langleyd pushed a commit that referenced this issue Mar 29, 2023
@jonnyandrew
fix: Include Espresso only in Android test configuration (#443)
b4b29ca 
Prevent dependency resolution errors e.g.
- element-hq/element-android#7883
- https://github.com/vector-im/element-android/actions/runs/3833639242/jobs/6525294449#step:9:1915
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@giomfo giomfo

Labels
P1 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
sprint2.2
Development

No branches or pull requests
4 participants
@manuroe @giomfo @ylecollen @matrixbot