scrollpanel tight recurses if no homeserver connection is available #18242
Labels
Comments
|
Looks like this broke in v1.7.31 (react-sdk 3.24.0) |
|
I'm not sure how we avoided this before, but adding / removing the pagination spinner causes ScrollPanel's |
dbkr
added a commit
to matrix-org/matrix-react-sdk
that referenced
this issue
Jul 26, 2021
I'm not really sure how this is meant to work - and I'm not sure how it was working before, but this is causing fairly bad infinite loops if I start element with no homeserver connection. This is a fairly crude fix, only thing I can think that would be better is some awareness of when network requests were failing and intentionally backing off. Fixes element-hq/element-web#18242
williamkray
pushed a commit
to williamkray/matrix-react-sdk
that referenced
this issue
Aug 2, 2021
* Sanitize untrusted variables from message previews before translation Fixes element-hq/element-web#18314 * Fix editing of `<sub>` & `<sup`> & `<u>` [\matrix-org#6469](matrix-org#6469) Fixes element-hq/element-web#18211 * Zoom images in lightbox to where the cursor points [\matrix-org#6418](matrix-org#6418) Fixes element-hq/element-web#17870 * Avoid hitting the settings store from TextForEvent [\matrix-org#6205](matrix-org#6205) Fixes element-hq/element-web#17650 * Initial MSC3083 + MSC3244 support [\matrix-org#6212](matrix-org#6212) Fixes element-hq/element-web#17686 and element-hq/element-web#17661 * Navigate to the first room with notifications when clicked on space notification dot [\matrix-org#5974](matrix-org#5974) * Add matrix: to the list of permitted URL schemes [\matrix-org#6388](matrix-org#6388) * Add "Copy Link" to room context menu [\matrix-org#6374](matrix-org#6374) * 💭 Message bubble layout [\matrix-org#6291](matrix-org#6291) Fixes element-hq/element-web#4635, element-hq/element-web#17773 element-hq/element-web#16220 and element-hq/element-web#7687 * Play only one audio file at a time [\matrix-org#6417](matrix-org#6417) Fixes element-hq/element-web#17439 * Move download button for media to the action bar [\matrix-org#6386](matrix-org#6386) Fixes element-hq/element-web#17943 * Improved display of one-to-one call history with summary boxes for each call [\matrix-org#6121](matrix-org#6121) Fixes element-hq/element-web#16409 * Notification settings UI refresh [\matrix-org#6352](matrix-org#6352) Fixes element-hq/element-web#17782 * Fix EventIndex double handling events and erroring [\matrix-org#6385](matrix-org#6385) Fixes element-hq/element-web#18008 * Improve reply rendering [\matrix-org#3553](matrix-org#3553) Fixes element-hq/element-web#9217, element-hq/element-web#7633, element-hq/element-web#7530, element-hq/element-web#7169, element-hq/element-web#7151, element-hq/element-web#6692 element-hq/element-web#6579 and element-hq/element-web#17440 * Fix CreateRoomDialog exploding when making public room outside of a space [\matrix-org#6493](matrix-org#6493) * Fix regression where registration would soft-crash on captcha [\matrix-org#6505](matrix-org#6505) Fixes element-hq/element-web#18284 * only send join rule event if we have a join rule to put in it [\matrix-org#6517](matrix-org#6517) * Improve the new download button's discoverability and interactions. [\matrix-org#6510](matrix-org#6510) * Fix voice recording UI looking broken while microphone permissions are being requested. [\matrix-org#6479](matrix-org#6479) Fixes element-hq/element-web#18223 * Match colors of room and user avatars in DMs [\matrix-org#6393](matrix-org#6393) Fixes element-hq/element-web#2449 * Fix onPaste handler to work with copying files from Finder [\matrix-org#5389](matrix-org#5389) Fixes element-hq/element-web#15536 and element-hq/element-web#16255 * Fix infinite pagination loop when offline [\matrix-org#6478](matrix-org#6478) Fixes element-hq/element-web#18242 * Fix blurhash rounded corners missing regression [\matrix-org#6467](matrix-org#6467) Fixes element-hq/element-web#18110 * Fix position of the space hierarchy spinner [\matrix-org#6462](matrix-org#6462) Fixes element-hq/element-web#18182 * Fix display of image messages that lack thumbnails [\matrix-org#6456](matrix-org#6456) Fixes element-hq/element-web#18175 * Fix crash with large audio files. [\matrix-org#6436](matrix-org#6436) Fixes element-hq/element-web#18149 * Make diff colors in codeblocks more pleasant [\matrix-org#6355](matrix-org#6355) Fixes element-hq/element-web#17939 * Show the correct audio file duration while loading the file. [\matrix-org#6435](matrix-org#6435) Fixes element-hq/element-web#18160 * Fix various timeline settings not applying immediately. [\matrix-org#6261](matrix-org#6261) Fixes element-hq/element-web#17748 * Fix issues with room list duplication [\matrix-org#6391](matrix-org#6391) Fixes element-hq/element-web#14508 * Fix grecaptcha throwing useless error sometimes [\matrix-org#6401](matrix-org#6401) Fixes element-hq/element-web#15142 * Update Emojibase and Twemoji and switch to IamCal (Slack-style) shortcodes [\matrix-org#6347](matrix-org#6347) Fixes element-hq/element-web#13857 and element-hq/element-web#13334 * Respect compound emojis in default avatar initial generation [\matrix-org#6397](matrix-org#6397) Fixes element-hq/element-web#18040 * Fix bug where the 'other homeserver' field in the server selection dialog would become briefly focus and then unfocus when clicked. [\matrix-org#6394](matrix-org#6394) Fixes element-hq/element-web#18031 * Standardise spelling and casing of homeserver, identity server, and integration manager [\matrix-org#6365](matrix-org#6365) * Fix widgets not receiving decrypted events when they have permission. [\matrix-org#6371](matrix-org#6371) Fixes element-hq/element-web#17615 * Prevent client hangs when calculating blurhashes [\matrix-org#6366](matrix-org#6366) Fixes element-hq/element-web#17945 * Exclude state events from widgets reading room events [\matrix-org#6378](matrix-org#6378) * Cache feature_spaces\* flags to improve performance [\matrix-org#6381](matrix-org#6381)
williamkray
pushed a commit
to williamkray/element-web
that referenced
this issue
Aug 2, 2021
* Sanitize untrusted variables from message previews before translation Fixes element-hq#18314 * Fix editing of `<sub>` & `<sup`> & `<u>` [\element-hq#6469](matrix-org/matrix-react-sdk#6469) Fixes element-hq#18211 * Zoom images in lightbox to where the cursor points [\element-hq#6418](matrix-org/matrix-react-sdk#6418) Fixes element-hq#17870 * Avoid hitting the settings store from TextForEvent [\element-hq#6205](matrix-org/matrix-react-sdk#6205) Fixes element-hq#17650 * Initial MSC3083 + MSC3244 support [\element-hq#6212](matrix-org/matrix-react-sdk#6212) Fixes element-hq#17686 and element-hq#17661 * Navigate to the first room with notifications when clicked on space notification dot [\element-hq#5974](matrix-org/matrix-react-sdk#5974) * Add matrix: to the list of permitted URL schemes [\element-hq#6388](matrix-org/matrix-react-sdk#6388) * Add "Copy Link" to room context menu [\element-hq#6374](matrix-org/matrix-react-sdk#6374) * 💭 Message bubble layout [\element-hq#6291](matrix-org/matrix-react-sdk#6291) Fixes element-hq#4635, element-hq#17773 element-hq#16220 and element-hq#7687 * Play only one audio file at a time [\#6417](matrix-org/matrix-react-sdk#6417) Fixes element-hq#17439 * Move download button for media to the action bar [\element-hq#6386](matrix-org/matrix-react-sdk#6386) Fixes element-hq#17943 * Improved display of one-to-one call history with summary boxes for each call [\element-hq#6121](matrix-org/matrix-react-sdk#6121) Fixes element-hq#16409 * Notification settings UI refresh [\element-hq#6352](matrix-org/matrix-react-sdk#6352) Fixes element-hq#17782 * Fix EventIndex double handling events and erroring [\element-hq#6385](matrix-org/matrix-react-sdk#6385) Fixes element-hq#18008 * Improve reply rendering [\element-hq#3553](matrix-org/matrix-react-sdk#3553) Fixes element-hq#9217, element-hq#7633, element-hq#7530, element-hq#7169, element-hq#7151, element-hq#6692 element-hq#6579 and element-hq#17440 * Improve performance of room name calculation [\element-hq#1801](matrix-org/matrix-js-sdk#1801) * Fix browser history getting stuck looping back to the same room [\element-hq#18053](element-hq#18053) * Fix space shortcuts on layouts with non-English keys in the places of numbers [\element-hq#17780](element-hq#17780) Fixes element-hq#17776 * Fix CreateRoomDialog exploding when making public room outside of a space [\element-hq#6493](matrix-org/matrix-react-sdk#6493) * Fix regression where registration would soft-crash on captcha [\element-hq#6505](matrix-org/matrix-react-sdk#6505) Fixes element-hq#18284 * only send join rule event if we have a join rule to put in it [\element-hq#6517](matrix-org/matrix-react-sdk#6517) * Improve the new download button's discoverability and interactions. [\element-hq#6510](matrix-org/matrix-react-sdk#6510) * Fix voice recording UI looking broken while microphone permissions are being requested. [\element-hq#6479](matrix-org/matrix-react-sdk#6479) Fixes element-hq#18223 * Match colors of room and user avatars in DMs [\element-hq#6393](matrix-org/matrix-react-sdk#6393) Fixes element-hq#2449 * Fix onPaste handler to work with copying files from Finder [\element-hq#5389](matrix-org/matrix-react-sdk#5389) Fixes element-hq#15536 and element-hq#16255 * Fix infinite pagination loop when offline [\element-hq#6478](matrix-org/matrix-react-sdk#6478) Fixes element-hq#18242 * Fix blurhash rounded corners missing regression [\element-hq#6467](matrix-org/matrix-react-sdk#6467) Fixes element-hq#18110 * Fix position of the space hierarchy spinner [\element-hq#6462](matrix-org/matrix-react-sdk#6462) Fixes element-hq#18182 * Fix display of image messages that lack thumbnails [\element-hq#6456](matrix-org/matrix-react-sdk#6456) Fixes element-hq#18175 * Fix crash with large audio files. [\element-hq#6436](matrix-org/matrix-react-sdk#6436) Fixes element-hq#18149 * Make diff colors in codeblocks more pleasant [\element-hq#6355](matrix-org/matrix-react-sdk#6355) Fixes element-hq#17939 * Show the correct audio file duration while loading the file. [\element-hq#6435](matrix-org/matrix-react-sdk#6435) Fixes element-hq#18160 * Fix various timeline settings not applying immediately. [\element-hq#6261](matrix-org/matrix-react-sdk#6261) Fixes element-hq#17748 * Fix issues with room list duplication [\element-hq#6391](matrix-org/matrix-react-sdk#6391) Fixes element-hq#14508 * Fix grecaptcha throwing useless error sometimes [\element-hq#6401](matrix-org/matrix-react-sdk#6401) Fixes element-hq#15142 * Update Emojibase and Twemoji and switch to IamCal (Slack-style) shortcodes [\element-hq#6347](matrix-org/matrix-react-sdk#6347) Fixes element-hq#13857 and element-hq#13334 * Respect compound emojis in default avatar initial generation [\element-hq#6397](matrix-org/matrix-react-sdk#6397) Fixes element-hq#18040 * Fix bug where the 'other homeserver' field in the server selection dialog would become briefly focus and then unfocus when clicked. [\element-hq#6394](matrix-org/matrix-react-sdk#6394) Fixes element-hq#18031 * Standardise spelling and casing of homeserver, identity server, and integration manager [\element-hq#6365](matrix-org/matrix-react-sdk#6365) * Fix widgets not receiving decrypted events when they have permission. [\element-hq#6371](matrix-org/matrix-react-sdk#6371) Fixes element-hq#17615 * Prevent client hangs when calculating blurhashes [\element-hq#6366](matrix-org/matrix-react-sdk#6366) Fixes element-hq#17945 * Exclude state events from widgets reading room events [\element-hq#6378](matrix-org/matrix-react-sdk#6378) * Cache feature_spaces\* flags to improve performance [\element-hq#6381](matrix-org/matrix-react-sdk#6381)
BBaoVanC
added a commit
to boba-best/element.boba.best
that referenced
this issue
Aug 3, 2021
* Sanitize untrusted variables from message previews before translation Fixes element-hq#18314 * Fix editing of `<sub>` & `<sup`> & `<u>` [\element-hq#6469](matrix-org/matrix-react-sdk#6469) Fixes element-hq#18211 * Zoom images in lightbox to where the cursor points [\element-hq#6418](matrix-org/matrix-react-sdk#6418) Fixes element-hq#17870 * Avoid hitting the settings store from TextForEvent [\element-hq#6205](matrix-org/matrix-react-sdk#6205) Fixes element-hq#17650 * Initial MSC3083 + MSC3244 support [\element-hq#6212](matrix-org/matrix-react-sdk#6212) Fixes element-hq#17686 and element-hq#17661 * Navigate to the first room with notifications when clicked on space notification dot [\element-hq#5974](matrix-org/matrix-react-sdk#5974) * Add matrix: to the list of permitted URL schemes [\element-hq#6388](matrix-org/matrix-react-sdk#6388) * Add "Copy Link" to room context menu [\element-hq#6374](matrix-org/matrix-react-sdk#6374) * 💭 Message bubble layout [\element-hq#6291](matrix-org/matrix-react-sdk#6291) Fixes element-hq#4635, element-hq#17773 element-hq#16220 and element-hq#7687 * Play only one audio file at a time [\#6417](matrix-org/matrix-react-sdk#6417) Fixes element-hq#17439 * Move download button for media to the action bar [\element-hq#6386](matrix-org/matrix-react-sdk#6386) Fixes element-hq#17943 * Improved display of one-to-one call history with summary boxes for each call [\element-hq#6121](matrix-org/matrix-react-sdk#6121) Fixes element-hq#16409 * Notification settings UI refresh [\element-hq#6352](matrix-org/matrix-react-sdk#6352) Fixes element-hq#17782 * Fix EventIndex double handling events and erroring [\element-hq#6385](matrix-org/matrix-react-sdk#6385) Fixes element-hq#18008 * Improve reply rendering [\element-hq#3553](matrix-org/matrix-react-sdk#3553) Fixes element-hq#9217, element-hq#7633, element-hq#7530, element-hq#7169, element-hq#7151, element-hq#6692 element-hq#6579 and element-hq#17440 * Improve performance of room name calculation [\element-hq#1801](matrix-org/matrix-js-sdk#1801) * Fix browser history getting stuck looping back to the same room [\element-hq#18053](element-hq#18053) * Fix space shortcuts on layouts with non-English keys in the places of numbers [\element-hq#17780](element-hq#17780) Fixes element-hq#17776 * Fix CreateRoomDialog exploding when making public room outside of a space [\element-hq#6493](matrix-org/matrix-react-sdk#6493) * Fix regression where registration would soft-crash on captcha [\element-hq#6505](matrix-org/matrix-react-sdk#6505) Fixes element-hq#18284 * only send join rule event if we have a join rule to put in it [\element-hq#6517](matrix-org/matrix-react-sdk#6517) * Improve the new download button's discoverability and interactions. [\element-hq#6510](matrix-org/matrix-react-sdk#6510) * Fix voice recording UI looking broken while microphone permissions are being requested. [\element-hq#6479](matrix-org/matrix-react-sdk#6479) Fixes element-hq#18223 * Match colors of room and user avatars in DMs [\element-hq#6393](matrix-org/matrix-react-sdk#6393) Fixes element-hq#2449 * Fix onPaste handler to work with copying files from Finder [\element-hq#5389](matrix-org/matrix-react-sdk#5389) Fixes element-hq#15536 and element-hq#16255 * Fix infinite pagination loop when offline [\element-hq#6478](matrix-org/matrix-react-sdk#6478) Fixes element-hq#18242 * Fix blurhash rounded corners missing regression [\element-hq#6467](matrix-org/matrix-react-sdk#6467) Fixes element-hq#18110 * Fix position of the space hierarchy spinner [\element-hq#6462](matrix-org/matrix-react-sdk#6462) Fixes element-hq#18182 * Fix display of image messages that lack thumbnails [\element-hq#6456](matrix-org/matrix-react-sdk#6456) Fixes element-hq#18175 * Fix crash with large audio files. [\element-hq#6436](matrix-org/matrix-react-sdk#6436) Fixes element-hq#18149 * Make diff colors in codeblocks more pleasant [\element-hq#6355](matrix-org/matrix-react-sdk#6355) Fixes element-hq#17939 * Show the correct audio file duration while loading the file. [\element-hq#6435](matrix-org/matrix-react-sdk#6435) Fixes element-hq#18160 * Fix various timeline settings not applying immediately. [\element-hq#6261](matrix-org/matrix-react-sdk#6261) Fixes element-hq#17748 * Fix issues with room list duplication [\element-hq#6391](matrix-org/matrix-react-sdk#6391) Fixes element-hq#14508 * Fix grecaptcha throwing useless error sometimes [\element-hq#6401](matrix-org/matrix-react-sdk#6401) Fixes element-hq#15142 * Update Emojibase and Twemoji and switch to IamCal (Slack-style) shortcodes [\element-hq#6347](matrix-org/matrix-react-sdk#6347) Fixes element-hq#13857 and element-hq#13334 * Respect compound emojis in default avatar initial generation [\element-hq#6397](matrix-org/matrix-react-sdk#6397) Fixes element-hq#18040 * Fix bug where the 'other homeserver' field in the server selection dialog would become briefly focus and then unfocus when clicked. [\element-hq#6394](matrix-org/matrix-react-sdk#6394) Fixes element-hq#18031 * Standardise spelling and casing of homeserver, identity server, and integration manager [\element-hq#6365](matrix-org/matrix-react-sdk#6365) * Fix widgets not receiving decrypted events when they have permission. [\element-hq#6371](matrix-org/matrix-react-sdk#6371) Fixes element-hq#17615 * Prevent client hangs when calculating blurhashes [\element-hq#6366](matrix-org/matrix-react-sdk#6366) Fixes element-hq#17945 * Exclude state events from widgets reading room events [\element-hq#6378](matrix-org/matrix-react-sdk#6378) * Cache feature_spaces\* flags to improve performance [\element-hq#6381](matrix-org/matrix-react-sdk#6381)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Once all the promises are done at the end it calls itself, but it has a depth param which isn't provided there... should it be? Either way, if you manage to get it into a state where there's no HS connection and it thinks it needs more history, it will just keep trying.
This smells like a bug with the recent TS conversion but I can't see exactly how it would have regressed.
The text was updated successfully, but these errors were encountered: