Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

ACL changes appear to be causing notifications in rooms #20788

Closed
turt2live opened this issue Jan 27, 2022 · 8 comments · Fixed by matrix-org/matrix-js-sdk#2333 or matrix-org/synapse#12601
Closed

ACL changes appear to be causing notifications in rooms #20788

turt2live opened this issue Jan 27, 2022 · 8 comments · Fixed by matrix-org/matrix-js-sdk#2333 or matrix-org/synapse#12601
Assignees
@SimonBrandner
Labels
A-Notifications O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Product More input needed from the Product team Z-WTF

Comments

@turt2live
Copy link
Member

They shouldn't, much like membership events don't
@kittykat
Copy link
Contributor

Experienced on:
Element version: cfa9721-react-efa1667d7e9d-js-67d362fdd93d
Olm version: 3.2.8
Chromium 96.0.4664.110 (Official Build) Arch Linux (64-bit) on GNOME with Wayland

@SimonBrandner SimonBrandner added A-Notifications O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist labels Jan 27, 2022
@ShadowJonathan
Copy link
Contributor

Personally, I'd like for these notifications to (optionally) stay, as I think they're notification-worthy for administrators, at the very least.

@babolivier babolivier mentioned this issue Jan 28, 2022
Closed
@germain-gg germain-gg added the X-Needs-Product More input needed from the Product team label Apr 13, 2022
@germain-gg
Copy link
Contributor

germain-gg commented Apr 13, 2022 •
edited
Loading

@daniellekirkwood would you be able to define what we're aiming for here? I don't think it's ready to build in its current state

@SimonBrandner
Copy link
Contributor

SimonBrandner commented Apr 22, 2022 •
edited
Loading

This is super annoying - does anyone mind raising it to S-Major?

@turt2live
Copy link
Member Author

@gsouquet which part of this is not actionable?

@turt2live
Copy link
Member Author

@SimonBrandner workarounds do exist, though are obtuse and annoying to implement - I don't think it qualifies for Major.

@germain-gg
Copy link
Contributor

@turt2live hmm I believe it's unclear whether we want that to be handled on Element or whether this would require some spec changes to make sure this does not notify ever

@turt2live
Copy link
Member Author

"yes" :p

We have code in Element which should help here, but also we probably want to spec a push rule.

@SimonBrandner SimonBrandner self-assigned this Apr 29, 2022
This was referenced Apr 29, 2022
Closed
Merged
Merged
Merged
erikjohnston pushed a commit to matrix-org/synapse that referenced this issue May 10, 2022
@SimonBrandner
Implement MSC3786: Add a default push rule to ignore m.room.server_ac…
ade3008 
…l events (#12601)

Fixes element-hq/element-web#20788
Implements matrix-org/matrix-spec-proposals#3786
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue May 28, 2022
@su-ex
Merge tag 'v18.0.0' into sc
4a5ee08 
* Implement changes to MSC2285 (private read receipts) ([\matrix-org#2221](matrix-org#2221)).
* Add support for HTML renderings of room topics ([\matrix-org#2272](matrix-org#2272)).
* Add stopClient parameter to MatrixClient::logout ([\matrix-org#2367](matrix-org#2367)).
* registration: add function to re-request email token ([\matrix-org#2357](matrix-org#2357)).
* Remove hacky custom status feature ([\matrix-org#2350](matrix-org#2350)).
* Remove default push rule override for MSC1930 ([\matrix-org#2376](matrix-org#2376)). Fixes element-hq/element-web#15439.
* Tweak thread creation & event adding to fix bugs around relations ([\matrix-org#2369](matrix-org#2369)). Fixes element-hq/element-web#22162 and element-hq/element-web#22180.
* Prune both clear & wire content on redaction ([\matrix-org#2346](matrix-org#2346)). Fixes element-hq/element-web#21929.
* MSC3786: Add a default push rule to ignore `m.room.server_acl` events ([\matrix-org#2333](matrix-org#2333)). Fixes element-hq/element-web#20788.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@SimonBrandner SimonBrandner

Labels
A-Notifications O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Product More input needed from the Product team Z-WTF
Projects
None yet
Milestone
No milestone
5 participants
@kittykat @germain-gg @turt2live @ShadowJonathan @SimonBrandner