Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix normalizing of homeserver #964

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ashfame
Copy link

@ashfame ashfame commented Dec 19, 2022

PR fixes the normalizing approach towards homeserver.

Before this PR, function wasn't able to normalize synapse.dev:8008 homeserver correctly.

Here is the output prior to this PR:

"synapse.dev" -> "https://synapse.dev"
"synapse.dev:8008" -> "null"
"https://matrix.org" -> "https://matrix.org"
"https://matrix.org:8080" -> "https://matrix.org:8080"
"http:// invalid" -> "https://http"

With the changes in PR, the output is as follows:

"synapse.dev" -> "https://synapse.dev"
"synapse.dev:8008" -> "https://synapse.dev:8008"
"https://matrix.org" -> "https://matrix.org"
"https://matrix.org:8080" -> "https://matrix.org:8080"
"http:// invalid" -> ""

Signed-off-by: Ashish Kumar ashfame@users.noreply.github.com

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant