Create one-off scheduled task to delete old OTKs #17934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
force-pushed
the
rav/drop_old_otks
branch
from
b14d93b to
cd9f855
Compare
To work around the fact that, pre-#17903, our database may have old one-time-keys that the clients have long thrown away the private keys for, we want to delete OTKs that look like they came from libolm. To spread the load a bit, without holding up other background database updates, we use a scheduled task to do the work.
richvdh
force-pushed
the
rav/drop_old_otks
branch
from
cd9f855 to
c030532
Compare
synapse/handlers/e2e_keys.py
Outdated
| """ | ||
| user = task.result.get("from_user", "") if task.result else "" | ||
| while True: | ||
| user, rowcount = await self.store.delete_old_otks_for_one_user(user) |
There was a problem hiding this comment.
Any chance we could do a number of users in a batch? Rather than trying to do ~25 transactions a second?
richvdh
force-pushed
the
rav/drop_old_otks
branch
from
68f3e91 to
a45bc22
Compare
erikjohnston
approved these changes
Nov 19, 2024
sandhose
pushed a commit
that referenced
this pull request
Nov 26, 2024
In a worker-mode deployment, the `E2eKeysHandler` is not necessarily loaded, which means the handler for the `delete_old_otks` task will not be registered. Make sure we load the handler. Introduced in #17934
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To work around the fact that, pre-#17903, our database may have old one-time-keys that the clients have long thrown away the private keys for, we want to delete OTKs that look like they came from libolm.
To spread the load a bit, without holding up other background database updates, we use a scheduled task to do the work.