Ele 4067 slack messaging integration #1822
Conversation
|
👋 @ofek1weiss |
elementary/messages/blocks.py
Outdated
| @@ -70,7 +80,7 @@ class DividerBlock(BaseBlock): | |||
|
|
|||
| class LineBlock(BaseBlock): | |||
| type: Literal["line"] = "line" | |||
| inlines: List[InlineBlock] | |||
| inlines: Sequence[InlineBlock] | |||
There was a problem hiding this comment.
changed to sequence for better typing
| @@ -162,12 +183,6 @@ def _add_expandable_block(self, block: ExpandableBlock) -> None: | |||
| Expandable blocks are not supported in Slack Block Kit. | |||
| However, slack automatically collapses a large section block into an expandable block. | |||
| """ | |||
| self._add_block( | |||
There was a problem hiding this comment.
adding the button label as a title in slack looked really bad, looks better without it
| timestamp=response["ts"], | ||
| ) | ||
|
|
||
| def _handle_send_err(self, err: SlackApiError, channel_name: str) -> bool: |
There was a problem hiding this comment.
from this point down, mainly adapted from the existing clients, with some tweaks
| @@ -70,13 +68,3 @@ def send_message( | |||
|
|
|||
| def supports_reply(self) -> bool: | |||
| return False | |||
|
|
|||
| def reply_to_message( | |||
There was a problem hiding this comment.
not needed, the base class does this
| lines=[ | ||
| LineBlock( | ||
| inlines=[ | ||
| MentionBlock(user="user1"), |
There was a problem hiding this comment.
added test for new inline types
| "LineBlock", | ||
| ] | ||
|
|
||
| LineBlock.update_forward_refs() |
There was a problem hiding this comment.
needed to join a subsection of the line with a different sep (the owners with a ',')
…le-4067-slack-messaging-integration
| integration=integration, | ||
| config=self.config, | ||
| metadata=metadata, | ||
| override_config_defaults=self.override_config_defaults, | ||
| ) | ||
| return integration.send_message(destination=destination, body=body) | ||
|
|
||
| def _send_test_message(self): |
There was a problem hiding this comment.
Actually in _send_alert too.
| ONE_SECOND = 1 | ||
|
|
||
|
|
||
| class SlackWebhookMessagingIntegration(BaseMessagingIntegration[None, None]): |
There was a problem hiding this comment.
I think it makes sense to align the type annotation with the Teams webhook integration.
In the Teams webhook integration, the webhook acts as a destination that can be provided to "send_message," whereas here, it serves as a parameter to initiate the integration.
…le-4067-slack-messaging-integration
…g (instead of as destination)
null