volume-control: don't mute monitor sources #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Middle-clicking the microphone indicator causes monitors to also be muted. This is confusing because if an user is recording their screen while using the indicator to mute and un-mute their microphone, the screen recording will be silent as well.
|
Side-effect I just noticed: this also fixes compatibility with cadmus - whereas before muting and unmuting would cause the sound from your microphone to get fed back to the speakers and create a devilishly loud loop. |
|
@lenemter could you check this one out please? Thanks! |
lenemter
approved these changes
Jun 2, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Middle-clicking the microphone indicator causes monitors to also be muted.
This is confusing because if an user is recording their screen while using the indicator to mute and un-mute their microphone, the screen recording will be silent as well.
Ask me how I know. :)