feat: bump node to v22, remove form data and fetch polyfills #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
talentlessguy
commented
Jan 22, 2025
| @@ -45,5 +39,9 @@ | |||
| "path": false, | |||
| "command-exists": false, | |||
| "execa": false | |||
| }, | |||
| "packageManager": "yarn@1.22.22+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e", | |||
There was a problem hiding this comment.
this was added by corepack, I can undo if needed
|
Shared this with the Fern team who will include some of these ideas upstream. |
|
is it possible to re-review this PR? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request upgrade minimum supported Node.js 22 and as a result:
Node 15 has been EOL since 2021, while Node 22 is the latest LTS, which has first-class fetch support (since node 18) as well as native
FormDatasupport. Both Vercel Edge runtime and Cloudflare support fetch and FormData first-class, so those polyfills are no longer necessary.