Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor(language): Rename from Filipino to Tagalog #294

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

jo-elimu
Copy link
Member

closes #293

@jo-elimu jo-elimu self-assigned this Jul 14, 2024
@jo-elimu jo-elimu requested a review from a team as a code owner July 14, 2024 11:21
@jo-elimu jo-elimu requested review from jpatel3, tomaszsmy and vuriaval and removed request for a team July 14, 2024 11:21
Copy link

coderabbitai bot commented Jul 14, 2024

Walkthrough

The change involves modifying the Language enum in the project by replacing the entry for "Filipino" with a new entry for "Tagalog". This update aims to better reflect the language designation, aligning with linguistic standards.

Changes

File Path Change Summary
src/main/java/ai/elimu/model/v2/enums/Language.java Removed the FIL("fil", "Filipino", "Pilipino") entry and added TGL("tgl", "Tagalog", "Tagalog").

Possibly related issues


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 54be95f and f679db5.

Files selected for processing (1)
  • src/main/java/ai/elimu/model/v2/enums/Language.java (1 hunks)
Additional comments not posted (1)
src/main/java/ai/elimu/model/v2/enums/Language.java (1)

12-12: Addition of TGL constant is correct.

The new TGL constant follows the existing pattern and conventions in the Language enum. The values "tgl", "Tagalog", and "Tagalog" are appropriate and consistent with the other constants.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jo-elimu jo-elimu merged commit ddc5171 into main Jul 14, 2024
9 checks passed
@jo-elimu jo-elimu deleted the 293-rename-to-tgl branch July 14, 2024 11:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename from Filipino to Tagalog
1 participant