Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor(analytics): limit to 100 most recent video learning events #1950

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

jo-elimu
Copy link
Member

Issue Number

Purpose

  • Needed because the page doesn't load when the database query returns hundreds of thousands of events.

Technical Details

Testing Instructions

Screenshots


Format Checks

Note

Files in PRs are automatically checked for format violations with mvn spotless:check.

If this PR contains files with format violations, run mvn spotless:apply to fix them.

@jo-elimu jo-elimu self-assigned this Nov 14, 2024
@jo-elimu jo-elimu requested a review from a team as a code owner November 14, 2024 11:38
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 15.96%. Comparing base (334677a) to head (7154c16).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...eb/analytics/VideoLearningEventListController.java 0.00% 16 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1950      +/-   ##
============================================
- Coverage     15.97%   15.96%   -0.01%     
  Complexity      482      482              
============================================
  Files           257      257              
  Lines          7852     7856       +4     
  Branches        808      809       +1     
============================================
  Hits           1254     1254              
- Misses         6548     6552       +4     
  Partials         50       50              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jo-elimu jo-elimu merged commit 1d370d7 into main Nov 14, 2024
8 of 10 checks passed
@jo-elimu jo-elimu deleted the 1894-limit-to-100 branch November 14, 2024 11:39
Copy link
Contributor

coderabbitai bot commented Nov 14, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces significant changes to the VideoLearningEventListController and the associated JSP file for displaying video learning events. Key modifications include updating how video learning events are logged and displayed, transitioning from monthly to weekly data aggregation, and enhancing the model attributes to reflect these changes. The JSP file has been updated to visualize the new weekly data structure, including a new CSV export feature.

Changes

File Path Change Summary
src/main/java/ai/elimu/web/analytics/VideoLearningEventListController.java - Updated handleRequest to log videoLearningEvents size.
- Added videoLearningEventCount attribute.
- Changed event aggregation from monthly to weekly.
- Renamed monthList to weekList and adjusted date formatting.
src/main/webapp/WEB-INF/jsp/analytics/video-learning-event/list.jsp - Updated title to display ${videoLearningEventCount}.
- Changed chart data iteration from ${monthList} to ${weekList}.
- Added CSV export button and toast notification.

Assessment against linked issues

Objective Addressed Explanation
Add REST API endpoint No REST API endpoint changes were made in this PR.
Include unit tests No unit tests were added or modified in this PR.
Input validation for the uploaded file No changes related to input validation were made.
Add JPA @Entity No JPA entity changes were introduced in this PR.
Create scheduled task importing CSVs to database No clear indication of CSV import task changes.
Update analytics dashboard Changes to the analytics dashboard were made.

Possibly related PRs

Suggested reviewers

  • jpatel3
  • vrudas
  • alexander-kuruvilla
  • Souvik-Cyclic

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add VideoLearningEvent
2 participants