Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[#184] gracefully handles server process shutdown #375
[#184] gracefully handles server process shutdown #375
Changes from all commits
5883c4a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I'm investigating a Cowboy shutdown issue for my gRPC service running version v0.9.0 in production. My client receives
{:error, %GRPC.RPCError{status: 13, message: "status got is 204 instead of 200"}}
when Cowboy shuts down.In my unit test, if I add this line
GRPC.Server.send_headers(stream, %{})
, my client receives{:error, %GRPC.RPCError{status: 13, message: ":stream_error: {:stream_error, :no_error, :\"Stream reset by server.\"}"}}
.How can I gracefully handle the service's endpoint shutdown from the client side? Should I send headers like retry or goaway to prompt the client to retry?
This file was deleted.
This file was deleted.