Skip to content

Commit

Permalink
Improve consistency of type rendering weight across OSes (#1677)
Browse files Browse the repository at this point in the history
Use normal/400 instead of light/300 in the sidebar if the UA string indicates a non-Apple OS.
  • Loading branch information
DavidOliver authored Mar 11, 2023
1 parent a07443e commit 8d9cf7c
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 0 deletions.
1 change: 1 addition & 0 deletions assets/css/_html.css
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
@import '@fontsource/lato/300.css';
@import '@fontsource/lato/400.css';
@import '@fontsource/lato/700.css';
@import '@fontsource/merriweather/300.css';
@import '@fontsource/merriweather/300-italic.css';
Expand Down
1 change: 1 addition & 0 deletions assets/css/settings.css
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@

#settings-modal-content .switch-button-container > div > p {
font-size: 14px;
font-weight: 300;
line-height: 1.4;
margin: 0;
padding-bottom: 6px;
Expand Down
9 changes: 9 additions & 0 deletions assets/css/sidebar.css
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,9 @@
line-height: 20px;
color: var(--sidebarMuted);
}
.non-apple-os .sidebar .sidebar-projectVersion {
font-weight: 400; /* Non-Apple OSes render small light type too thinly */
}

.sidebar .sidebar-projectVersionsDropdown {
cursor: pointer;
Expand Down Expand Up @@ -128,6 +131,9 @@
font-size: 14px;
color: var(--sidebarMuted);
}
.non-apple-os .sidebar .sidebar-listNav :is(li, li a) {
font-weight: 400; /* Non-Apple OSes render small light type too thinly */
}

.sidebar .sidebar-listNav li {
display: inline-block;
Expand Down Expand Up @@ -359,6 +365,9 @@
margin-right: 0;
color: var(--sidebarAccentMain);
}
.non-apple-os .sidebar #full-list ul li {
font-weight: 400; /* Non-Apple OSes render small light type too thinly */
}

.sidebar #full-list ul li.current-hash {
color: var(--sidebarActiveItem);
Expand Down
2 changes: 2 additions & 0 deletions assets/js/entry/html.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import { initialize as initTooltips } from '../tooltips/tooltips'
import { initialize as initHintsPage } from '../tooltips/hint-page'
import { initialize as initCopyButton } from '../copy-button'
import { initialize as initSettings } from '../settings'
import { initialize as initOs } from '../os'

onDocumentReady(() => {
initTheme()
Expand All @@ -33,4 +34,5 @@ onDocumentReady(() => {
initSearchPage()
initCopyButton()
initSettings()
initOs()
})
6 changes: 6 additions & 0 deletions assets/js/os.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
export function initialize () {
const appleDeviceExpr = /(Macintosh|iPhone|iPad|iPod)/

const osClass = appleDeviceExpr.test(window.navigator.userAgent) ? 'apple-os' : 'non-apple-os'
document.documentElement.classList.add(osClass)
}

0 comments on commit 8d9cf7c

Please # to comment.