Don't crash on code blocks like "A.b.C", closes #1285

elixir-lang · Oct 12, 2020 · c23302a · c23302a
1 parent a4a497d
commit c23302a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/lib/ex_doc/autolink.ex b/lib/ex_doc/autolink.ex
@@ -288,9 +288,18 @@ defmodule ExDoc.Autolink do
 
   defp do_parse_module(string) do
     case Code.string_to_quoted(string, warn_on_unnecessary_quotes: false) do
-      {:ok, module} when is_atom(module) -> {:module, module}
-      {:ok, {:__aliases__, _, parts}} -> {:module, Module.concat(parts)}
-      _ -> :error
+      {:ok, module} when is_atom(module) ->
+        {:module, module}
+
+      {:ok, {:__aliases__, _, parts}} ->
+        if Enum.all?(parts, &is_atom/1) do
+          {:module, Module.concat(parts)}
+        else
+          :error
+        end
+
+      _ ->
+        :error
     end
   end
 

diff --git a/test/ex_doc/autolink_test.exs b/test/ex_doc/autolink_test.exs
@@ -33,6 +33,7 @@ defmodule ExDoc.AutolinkTest do
     test "unknown module" do
       assert_unchanged("Unknown")
       assert_unchanged(":unknown")
+      assert_unchanged("A.b.C")
     end
 
     test "project-local module" do