-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add dracula style #14
base: gh-pages
Are you sure you want to change the base?
Conversation
@@ -57,8 +57,6 @@ <h2>Languages</h2> | |||
|
|||
<li class="toctree-l1"><a class="reference internal" href="html.html">HTML</a></li> | |||
|
|||
<li class="toctree-l1"><a class="reference internal" href="json.html">JSON</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why this is removed, I did not see JSON on the master branch either. But it is on the demo site.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, I forgot to push to master. I have done that now, can you please rebase? Also, please commit your changes to master. I will rebuild the website after merging. :)
Quick question, from where does the dracula css rules come from? |
There aren't any strict rules as far as I can tell. I looked at a few implementations of the dracula theme and it looks different on VIM and VSCODE for example. I am doing my best to apply the CSS rules based n what I see from the other dracula implementations. |
Actually it looks like there are guidelines over here: https://spec.draculatheme.com/# |
What I mean is that I think new styles have to be contributed to the |
c102bb3
to
4c112b6
Compare
Oh got you, I am working on another PR for that. Will push both just now. |
Sorry about the delay. I only saw your message now:
Should I push my change to master? Or should I rebase and push the update to this PR? I think the changes have been merged in now, and the website can be rebuilt. |
I will regenerate this once a new makeup version is out. :) |
Add dracula style, and tested locally.