Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add dracula style #14

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

fbuys
Copy link

@fbuys fbuys commented May 20, 2023

Add dracula style, and tested locally.

image

@@ -57,8 +57,6 @@ <h2>Languages</h2>

<li class="toctree-l1"><a class="reference internal" href="html.html">HTML</a></li>

<li class="toctree-l1"><a class="reference internal" href="json.html">JSON</a></li>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this is removed, I did not see JSON on the master branch either. But it is on the demo site.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I forgot to push to master. I have done that now, can you please rebase? Also, please commit your changes to master. I will rebuild the website after merging. :)

@fbuys fbuys marked this pull request as draft May 20, 2023 15:35
@josevalim
Copy link
Contributor

Quick question, from where does the dracula css rules come from?

@fbuys
Copy link
Author

fbuys commented May 20, 2023

Quick question, from where does the dracula css rules come from?

There aren't any strict rules as far as I can tell. I looked at a few implementations of the dracula theme and it looks different on VIM and VSCODE for example.

I am doing my best to apply the CSS rules based n what I see from the other dracula implementations.
Like these:

@fbuys
Copy link
Author

fbuys commented May 20, 2023

Actually it looks like there are guidelines over here: https://spec.draculatheme.com/#

@josevalim
Copy link
Contributor

What I mean is that I think new styles have to be contributed to the makeup project, and then they will automatically show up here. :)

@fbuys fbuys force-pushed the fbuys/add-dracula-to-pages branch from c102bb3 to 4c112b6 Compare May 20, 2023 19:41
@fbuys
Copy link
Author

fbuys commented May 20, 2023

What I mean is that I think new styles have to be contributed to the makeup project, and then they will automatically show up here. :)

Oh got you, I am working on another PR for that. Will push both just now.

@fbuys fbuys marked this pull request as ready for review May 20, 2023 19:43
@fbuys
Copy link
Author

fbuys commented Jun 4, 2023

Sorry about the delay. I only saw your message now:

My bad, I forgot to push to master. I have done that now, can you please rebase? Also, please commit your changes to master. I will rebuild the website after merging. :)

Should I push my change to master? Or should I rebase and push the update to this PR?

I think the changes have been merged in now, and the website can be rebuilt.

@josevalim
Copy link
Contributor

I will regenerate this once a new makeup version is out. :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants