This repository was archived by the owner on Mar 19, 2021. It is now read-only.
Row.from fails to parse decimal data types in some cases. #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a new unit test to
row_test.exs
which explores an issue I've seen trying to bring sqlite_ecto up to speed on current Elixir, OTP, and eventually Ecto.As shown in https://travis-ci.org/scouten/sqlitex/builds/186397549, which targets the branch from this PR, the OTP 18 builds succeed, but the OTP 19 builds fail. FWIW if I run this on my Mac using OTP 19, it succeeds.
I suspect this might be indicative of a larger OTP 19 issue, but wanted to bring this to your attention ASAP.