Skip to content
This repository was archived by the owner on Mar 19, 2021. It is now read-only.

Row.from fails to parse decimal data types in some cases. #45

Merged
merged 4 commits into from
Dec 24, 2016
Merged

Row.from fails to parse decimal data types in some cases. #45

merged 4 commits into from
Dec 24, 2016

Conversation

scouten
Copy link

@scouten scouten commented Dec 23, 2016

I've added a new unit test to row_test.exs which explores an issue I've seen trying to bring sqlite_ecto up to speed on current Elixir, OTP, and eventually Ecto.

As shown in https://travis-ci.org/scouten/sqlitex/builds/186397549, which targets the branch from this PR, the OTP 18 builds succeed, but the OTP 19 builds fail. FWIW if I run this on my Mac using OTP 19, it succeeds.

I suspect this might be indicative of a larger OTP 19 issue, but wanted to bring this to your attention ASAP.

@mmmries
Copy link
Collaborator

mmmries commented Dec 23, 2016

Hello, @scouten! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

@mmmries
Copy link
Collaborator

mmmries commented Dec 23, 2016

Thanks @scouten! I'll try to take a closer look tonight when my kids are asleep.

@scouten
Copy link
Author

scouten commented Dec 24, 2016

This looks like fallout from an OTP 19.0 bug. Please see elixir-lang/elixir#5586 (comment).

The test may still be useful, but you should probably drop 19.0 from your test matrix if so. Consider using 19.1 or 19.2 instead. I'll amend the PR accordingly.

@mmmries
Copy link
Collaborator

mmmries commented Dec 24, 2016

👍 relying on 19.1+ sounds like a good solution to me

I'll get this merged and released

@mmmries mmmries merged commit a1d44dc into elixir-sqlite:master Dec 24, 2016
@mmmries
Copy link
Collaborator

mmmries commented Dec 24, 2016

released as v1.0.2

@scouten scouten deleted the new-decimal-debug branch December 30, 2016 04:14
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants