Row.from fails to parse decimal data types in some cases. #45
Conversation
|
Hello, @scouten! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information. |
|
Thanks @scouten! I'll try to take a closer look tonight when my kids are asleep. |
|
This looks like fallout from an OTP 19.0 bug. Please see elixir-lang/elixir#5586 (comment). The test may still be useful, but you should probably drop 19.0 from your test matrix if so. Consider using 19.1 or 19.2 instead. I'll amend the PR accordingly. |
This reverts commit 23c785e.
…a bug that affects this case. See elixir-lang/elixir#5586 (comment).
|
👍 relying on 19.1+ sounds like a good solution to me I'll get this merged and released |
|
released as v |
I've added a new unit test to
row_test.exswhich explores an issue I've seen trying to bring sqlite_ecto up to speed on current Elixir, OTP, and eventually Ecto.As shown in https://travis-ci.org/scouten/sqlitex/builds/186397549, which targets the branch from this PR, the OTP 18 builds succeed, but the OTP 19 builds fail. FWIW if I run this on my Mac using OTP 19, it succeeds.
I suspect this might be indicative of a larger OTP 19 issue, but wanted to bring this to your attention ASAP.