-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: Add CoinGecko plugin #1382
Conversation
Seems unnecessary to change the character files (provider switched for whatever reason), also the entire package.json instead of just adding the plugin. I know that's just a formatting thing but makes it more tedious to review. |
Ahh nm I see you added those characters originally. Just seemed unrelated to the PR. |
had some problems on DEV branch with antropic so I did change model to openai, but reverted now on this PR, as this is unrelated. |
about formating, isnt the setting for prettier set to 4 in all places, so seems to me this should be right formating of .json file? |
Going to test this but there are merge conflicts that need to be fixed. Might need to rebase this onto current develop branch to fix. I'm seeing some stuff that doesn't exist in current develop i.e. agent/src/index.ts everything but the addition of the import and |
thanx for review, develop moves fast so I didn't update it for 2 days and lots has changed, I merged current develop into mine so now there shouldn't be any conflict. |
This looks really clean now. Unfortunately I encountered an error attempting to test price retrieval -
|
try with openai as modelProvider, IDK why when using anthropic it gets this error, doesnt seem like problem with this plugin as it just sets "ModelClass.SMALL" and then in tiktoken module
this part gets some model that is not in the list, but seems more like general codebase problem, as I dont set the actual model in plugin. Please trace it out yourself and let me know what you think? |
hey @0xCardinalError @odilitime , thanks for working on this! I work on CoinGecko product, I can supply pro api key to ease your testing, and as token of appreciation for your contributions. Feel free to ping TG @soonegg91 There's more can be done here for eliza with the CG demo and pro api, happy to bounce ideas. |
hey, thnx. will contact him in pvt and see where we can take this to |
@odilitime @proteanx is testing done, Is anything else needed for this PR? |
Thanks for testing it out. The current commits include these 2 endpoints that support 24hr price change and 24hr trading volume data, but don't think it's included in the code:
Able to replicate this issue. It works for 'bitcoin', but not the following (refer image below):
![]() In case this helps - for 'chainId', this is how CoinGecko API maps with 'asset_platform_id'
-- There's definitely a lot more data and functionalities can be added given the API has more than 70 endpoints. Perhaps, can let 0xCardinalError focus on shipping the initial scopes, and can continue to expand to support more use cases. Hoping to see more contributors collab too :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, resolve @sachiew 's comment and merge conflicts plz
testing more
this works but not good all the time! |
yes, there are a lot of endpoints, started from the most logical one :) about the base problem, hmm it could also be down to quirkiness of actual LLM/char you are using. I tried exact same many times and it does output correctly as seen below. about ordinals, yeah, that is a problem, optimizing template for it and other to use ordinals word as platform/chain |
please provide if you have different problems then the ones stated by others? |
was solved and merged in other PRs, so will close this one |
Adding a new plugin, where with free API from coingecko we can get price of a currency and its marketcap.
There are 2 actions, so we can fetch by name/ticker but also with address of token.
Added, Readme, .env config and integration to default agent if key is set.
Image attached for example how it makes output.
