-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: allow passing secrets through environment #1454
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freytes
approved these changes
Dec 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good documentation, I would recommend a refactor for AWS
Freytes
approved these changes
Dec 26, 2024
twilwa
approved these changes
Dec 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok at a glance
1to3for5vi7ate9x
pushed a commit
to 1to3for5vi7ate9x/eliza
that referenced
this pull request
Jan 26, 2025
feat: allow passing secrets through environment
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resubmit #410
Relates to:
N/A
Risks
Medium - This PR adds a new feature for character-specific environment variable namespacing.
Risks include:
Background
I wanted to be able to check in character files without having to sanitize them first
What does this PR do?
Feature Implementation
Adds support for character-specific namespaced environment variables:
CHARACTER.YOUR_CHARACTER_NAME.SETTING_NAME
Key changes:
packages/core/src/settings.ts
packages/agent/src/index.ts
Documentation Updates
Updated documentation to reflect the new feature:
What kind of change is this?
Features (non-breaking change which adds functionality)
Documentation changes needed?
Yes - Documentation has been updated to reflect the new feature:
Testing
Where should a reviewer start?
Feature Testing
Review code changes:
packages/core/src/settings.ts
packages/agent/src/index.ts
Test functionality:
Documentation Testing
Review updated docs:
Detailed testing steps
Feature Testing:
Documentation Verification:
Screenshots
N/A - Feature implementation and documentation changes