Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Fix bug in plugin-bootstrap/src/evaluators/facts.ts #1648

Merged
merged 3 commits into from
Jan 1, 2025

Conversation

metakai1
Copy link
Contributor

@metakai1 metakai1 commented Jan 1, 2025

{{user1}} should be {{user2}} :


in factEvaluator, in the examples template,

{{user1}} should be {{user2}} instead

            {
                user: "{{user1}}",
                content: { text: "Which city?" },
            },
            {
                user: "{{user2}}",
                content: { text: "Oakland" },
            },
            {
                user: "{{user1}}",
                content: {
                    text: "Oh, I've never been there, but I know it's in California",
                },
            }

Relates to:

Risks

Background

What does this PR do?

What kind of change is this?

Documentation changes needed?

Testing

Where should a reviewer start?

Detailed testing steps

{{user1}} should be {{user2}} :

-------
in factEvaluator, in the examples template,

{{user1}} should be {{user2}} instead

                {
                    user: "{{user1}}",
                    content: { text: "Which city?" },
                },
                {
                    user: "{{user2}}",
                    content: { text: "Oakland" },
                },
                {
                    user: "{{user1}}",
                    content: {
                        text: "Oh, I've never been there, but I know it's in California",
                    },
                }
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @metakai1! Welcome to the ai16z community. Thanks for submitting your first pull request; your efforts are helping us accelerate towards AGI. We'll review it shortly. You are now a ai16z contributor!

@monilpat monilpat changed the base branch from main to develop January 1, 2025 20:24
@monilpat monilpat changed the title Fix bug in plugin-bootstrap/src/evaluators/facts.ts fix: Fix bug in plugin-bootstrap/src/evaluators/facts.ts Jan 1, 2025
Copy link
Collaborator

@monilpat monilpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@monilpat monilpat merged commit 8fd7f93 into elizaOS:develop Jan 1, 2025
3 checks passed
1to3for5vi7ate9x pushed a commit to 1to3for5vi7ate9x/eliza that referenced this pull request Jan 26, 2025
fix: Fix bug in plugin-bootstrap/src/evaluators/facts.ts
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants