Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Swap functionality #197

Merged
merged 5 commits into from
Nov 5, 2024
Merged

Swap functionality #197

merged 5 commits into from
Nov 5, 2024

Conversation

lalalune
Copy link
Member

@lalalune lalalune commented Nov 4, 2024

This PR enables swap functionality

MarcoMandar and others added 5 commits November 3, 2024 22:40
Signed-off-by: MarcoMandar <malicemandar@gmail.com>
Signed-off-by: MarcoMandar <malicemandar@gmail.com>
@lalalune lalalune requested a review from MarcoMandar November 4, 2024 11:28
Copy link
Collaborator

@MarcoMandar MarcoMandar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good!


console.log("Decimals:", decimals);

const adjustedAmount = amount * (10 ** decimals);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should use BN to avoid issues here

@lalalune lalalune merged commit 923ea75 into main Nov 5, 2024
1 check passed
@lalalune lalalune deleted the swap-functionality branch November 5, 2024 03:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants