-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: Add Custom System Prompt Support for plugin-image-generation #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odilitime
previously approved these changes
Dec 14, 2024
SImple conflict that needs to be resolve, otherwise LGTM |
I update to the latest "develop" branch and run the approval again. Seems no conflict? |
shakkernerd
approved these changes
Dec 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good work!
1to3for5vi7ate9x
pushed a commit
to 1to3for5vi7ate9x/eliza
that referenced
this pull request
Jan 26, 2025
feat: Add Custom System Prompt Support for plugin-image-generation
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
Image generation quality improvement and prompt engineering
Risks
Low - Adds new optional parameter for system prompts and enhanced image prompt generation without modifying core functionality.
Background
What does this PR do?
This PR enhances the text generation system by:
customSystemPrompt
parameter to generateText function for image gen system promptWhat kind of change is this?
Features (non-breaking change which adds functionality)
Why are we doing this?
To improve image generation quality by providing structured, detailed prompts that consider key aspects like:
Documentation changes needed?
My changes require a change to the project documentation to document:
customSystemPrompt
parameter in generateTextTesting
Where should a reviewer start?
packages/core/src/generation.ts
Detailed testing steps
I tested locally by running
pnpm start
with a new character that had ModelProviderName.HEURIST as the modelProvider and "direct" in the clients. Everything seemed to work well.Deploy Notes
No special deployment steps required. Feature is automatically active when using the plugin-image-generation functionality.
Discord username
tao8617