[ENHANCEMENT] - Replace unicode codepoints without regex #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
LitEmoji::unicodeToShortcode()
function so that known emoji are replaced with their corresponding shortcodes usingstr_replace
. The previous approach involved tokenizing the input string using regex generated from a list of known emoji, but this had several drawbacks:Because
str_replace
does not take multibyte character encodings into consideration, all replacement must happen in the encoding of the emoji in the$search
argument (in our case UTF-8). For this reason, all functions now convert to UTF-8 internally and return results in the original encoding. These functions will attempt to detect the encoding of the input string automatically and will assume UTF-8 when this fails. A second argument can also be passed to these functions to hint at the input string's encoding, e.g.LitEmoji::unicodeToShortcode('I like 🍦!', 'UTF-32')
.The returned string will be in the original encoding.
In addition to this enhancement, the library now requires PHP 7.4 or greater and has been updated to make use of newer features.