Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Backport x/sys upgrade to 0.16 release to support go 1.17 #1390

Merged
merged 1 commit into from
Aug 27, 2021
Merged

Backport x/sys upgrade to 0.16 release to support go 1.17 #1390

merged 1 commit into from
Aug 27, 2021

Conversation

stefanb
Copy link

@stefanb stefanb commented Aug 25, 2021

Backport just x/sys upgrade from c99d6e1 to v0.16-release branch so that next 1.16.* release will support go 1.17.

More context:

After merging it please:

  • make / tag a new release (eg v0.16.2 on v0.16-release branch)

Simpler alternative to #1388
Fixes #1389

Altrenatively you can make a new release branch (eg v0.17-release) from the master branch somewhere after c99d6e1 and tag a new release (eg v0.17.0) there, but that might include other, unrelated changes.

Backport just x/sys upgrade from c99d6e1 to v0.16-release branch

Alternative to & closes #1388
@stefanb stefanb changed the title Backport x/sys upgrade to 0.16 release Backport x/sys upgrade to 0.16 release to support go 1.17 Aug 25, 2021
@xiaq xiaq merged commit 980a391 into elves:v0.16-release Aug 27, 2021
@xiaq
Copy link
Member

xiaq commented Aug 27, 2021

I've tagged v0.16.2 too.

@stefanb stefanb deleted the 0.16-backport-x-sys-upgrade-1.17 branch August 28, 2021 05:11
@stefanb
Copy link
Author

stefanb commented Aug 28, 2021

Thanks, @xiaq !

@xiaq
Copy link
Member

xiaq commented Aug 28, 2021

Hmm, this broke the building of the website because the x/sys dependency was not in website/go.mod.

I'll fix that and bump to 0.16.3...

@stefanb
Copy link
Author

stefanb commented Aug 28, 2021

Tnx! I was testing using Makefile and all tests passed as in CI. With initial PR #1388 on master i updated both go.mod files 😇

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants