Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Will it cause performance impact when writing file log use default FilePrinter? #8

Closed
evilfate opened this issue Nov 21, 2016 · 2 comments
Labels
suggestion New feature user ask for

Comments

@evilfate
Copy link

As title, we have some concern about performance impact.

@elvishew
Copy link
Owner

@evilfate It depends on how often you print an log. The default FilePrinter just write the log to the file and flush immediately, so if you print a lot of logs in your release app, I think it would impact the performance.
From my test and general usage, I think it's OK.
If you finally find writing file log impact the performance, you'd better implement you printer, not flush the file every time right after writing the log to the file.

@elvishew
Copy link
Owner

elvishew commented Dec 8, 2016

Optimise the FilePrinter, print to file asynchronously.

@elvishew elvishew closed this as completed Dec 8, 2016
@elvishew elvishew added suggestion New feature user ask for and removed enhancement labels Oct 23, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
suggestion New feature user ask for
Projects
None yet
Development

No branches or pull requests

2 participants