Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Pipeline unit tests create two artifacts in source directories #3116

Closed
kevin-bates opened this issue Feb 28, 2023 · 1 comment · Fixed by #3117
Closed

Pipeline unit tests create two artifacts in source directories #3116

kevin-bates opened this issue Feb 28, 2023 · 1 comment · Fixed by #3117
Assignees
Labels
component:test Test-related kind:bug Something isn't working

Comments

@kevin-bates
Copy link
Member

Whenever I run server-side pipeline tests (e.g., pytest -v elyra/tests/pipeline) there are two artifacts produced that make it annoying when trying to check in and commit changes. Following the tests, a git status command will produce the following:

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	elyra/tests/pipeline/resources/test_pipelines/kfp/kfp-multi-node-generic.yaml
	elyra/tests/pipeline/resources/test_pipelines/kfp/kfp-one-node-generic.yaml

These files must first be cleared before their accidental inclusion into git.

If these are necessary to validate functionality, the test should make appropriate use of temporary directories so that these do not appear within the population of source-controlled files.

@kevin-bates kevin-bates added kind:bug Something isn't working component:test Test-related status:Needs Triage labels Feb 28, 2023
@ptitzler
Copy link
Member

ptitzler commented Mar 1, 2023

I'll take a look. These are code gen test artifacts.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
component:test Test-related kind:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants