Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix test artifact output location bugs #3117

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

ptitzler
Copy link
Member

@ptitzler ptitzler commented Mar 1, 2023

Fixes #3116. The root cause are two KFP processor tests, which produce the YAML file artifacts due to bugs:

$ pytest elyra/tests/pipeline/kfp/test_processor_kfp.py -k test_generate_pipeline_dsl_compile_pipeline_dsl_one_generic_node_pipeline_test_2

$ pytest elyra/tests/pipeline/kfp/test_processor_kfp.py -k test_generate_pipeline_dsl_compile_pipeline_dsl_generic_components_data_exchange

What changes were proposed in this pull request?

Strip absolute path information from generated file names

How was this pull request tested?

  • pytest elyra/tests/pipeline/kfp/test_processor_kfp.py passes all tests and git status does not list any new artifacts
$ pytest -v elyra/tests/pipeline
 ...
======================================== 222 passed, 8 warnings in 55.19s ========================================
$ git status
On branch code-gen-test-artifacts
nothing to commit, working tree clean

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Signed-off-by: Patrick Titzler <ptitzler@us.ibm.com>
@ptitzler ptitzler added kind:bug Something isn't working component:test Test-related labels Mar 1, 2023
@ptitzler ptitzler requested a review from kevin-bates March 1, 2023 16:21
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @ptitzler - thank you!

@kevin-bates kevin-bates merged commit aba03a1 into elyra-ai:main Mar 1, 2023
@ptitzler ptitzler deleted the code-gen-test-artifacts branch March 1, 2023 18:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
component:test Test-related kind:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pipeline unit tests create two artifacts in source directories
2 participants