Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Lower floor for kfp-tekton dependency #3125

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

ptitzler
Copy link
Member

@ptitzler ptitzler commented Mar 13, 2023

Lower floor for kfp-tekton dependency to version 1.5.2 to re-establish compatibility with older versions of Tekton. Since version 1.6+ includes breaking API changes (v1beta1 -> v1), users will have to manually choose the kfp-tekton package version that is compatible with the Tekton version that's installed on the server.

What changes were proposed in this pull request?

  • Lower kfp-tekton dependency to support older releases of Tekton.

How was this pull request tested?

  • pip installed kfp-tekton 1.5.2
  • pip installed Elyra
  • confirmed that Elyra can submit a pipeline on a cluster where Tekton Pipelines v0.33.2 is deployed

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Signed-off-by: Patrick Titzler <ptitzler@us.ibm.com>
@ptitzler ptitzler added the dependencies Pull requests that update a dependency file label Mar 13, 2023
@ptitzler ptitzler added this to the 3.15.0 milestone Mar 13, 2023
@ptitzler ptitzler added the status:Work in Progress Development in progress. A PR tagged with this label is not review ready unless stated otherwise. label Mar 13, 2023
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ptitzler.

@ptitzler ptitzler removed the status:Work in Progress Development in progress. A PR tagged with this label is not review ready unless stated otherwise. label Mar 13, 2023
@ptitzler ptitzler merged commit 2ff70c5 into elyra-ai:main Mar 13, 2023
@ptitzler ptitzler deleted the fix-kfp-tekton-dependency branch March 13, 2023 22:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants