New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Optional `BooleanString` decoding issue #907

Open

crishoj wants to merge 2 commits into elysiajs:main from crishoj:optional-boolean-string-decoding-issue

Contributor

crishoj commented Nov 3, 2024

Possible fix for #872:

Using the following schema, the query string ?other=foo is rejected with 422 expected boolean.

t.Object({
    registered: t.Optional(t.Boolean()),
    other: t.String(),
})

The validation error is thrown in BooleanString.Decode.

@bogeychan please correct me if I'm wrong — I assume the intention in Decode is to check if value is present, not property?

crishoj added 2 commits

November 3, 2024 20:48


          add failing test case for elysiajs#872

c6af9a8


          possible fix for optional BooleanString decoding issue (elysiajs#872)

1869e8b

crishoj mentioned this pull request

Typebox Boolean regression in 1.1.17 #872

Open

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet