Alpine support

[melezhik]

This is just a draft. For some reasons some of tests fail on SparrowCI - https://ci.sparrowhub.io/report/1488

[melezhik]

02:54:29 :: === RUN   TestPkgsToInstall
02:54:29 :: 2022/11/03 02:54:29 [ERROR] running /sbin/apk info -qe coreutils: 'exit status 1'
02:54:29 :: 2022/11/03 02:54:29 [INFO] coreutils not installed
02:54:29 ::     util.go:79: true != false
02:54:29 :: 2022/11/03 02:54:29 [ERROR] running /sbin/apk info -qe coreutils: 'exit status 1'
02:54:29 :: 2022/11/03 02:54:29 [INFO] coreutils not installed
02:54:29 :: 2022/11/03 02:54:29 [ERROR] running /sbin/apk info -qe freedoom: 'exit status 1'
02:54:29 :: 2022/11/03 02:54:29 [INFO] freedoom not installed
02:54:29 :: --- FAIL: TestPkgsToInstall (0.07s)

I guess this is because coreutils are not preinstalled on vanilla Alpine Linux

[melezhik]

it boils down to this assumption (not met on Alpine) - https://github.com/ema/pets/blob/master/planner_test.go#L15-L17

  // Test with one package already installed
  pf, err := NewPetsFile("/dev/null", "coreutils", "/etc/passwd", "root", "root", "0640", "", "")
  assertNoError(t, err)

[melezhik]

util.go:79: /bin/chmod 0644 /dev/null != /usr/bin/chmod 0644 /dev/null

This is because assumption for location of chmod for alpine is wrong -

pets/planner_test.go

Line 112 in e3d78d1

assertEquals(t, pa.Command.String(), "/usr/bin/chown nobody:root /etc/passwd")

pa := Chmod(pf)
  if pa != nil {
    t.Errorf("Expecting nil, got %v instead", pa)
  }

  pf.AddMode("0644")

  pa = Chmod(pf)

  assertEquals(t, pa.Cause.String(), "CHMOD")
  assertEquals(t, pa.Command.String(), "/usr/bin/chmod 0644 /dev/null")

it's indeed at /bin/chmod

[ema]

Two comments, LGTM otherwise! Thanks.

[ema]

Indentation looks off here, please use go fmt.

[ema]

Missing \n.

[melezhik]

please see now ...

[ema]

Nice, thank you!