Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

circe-command-FOOL: regexp-quote the nick #288

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

offby1
Copy link

@offby1 offby1 commented Sep 16, 2016

I hope the intent is obvious.

I hope the intent is obvious.
@wasamasa
Copy link
Collaborator

Not quite.

  • Why does this only apply to /fool, not /ignore as well?
  • How does one use regex if the need arises?
  • This is not bullet-proof in terms of matching. Assuming you /fool 123 and there is someone with a ~user@foobar123.host.org usermask, they will get filtered as well. This occurred to me a few times and needed to be solved with anchoring. See Ignore rewrite #28 for more thoughts on the topic.

@jorgenschaefer jorgenschaefer added this to the v2.4 milestone Sep 16, 2016
@jorgenschaefer
Copy link
Collaborator

Thank you for the contribution! :-) wasamasa has some good questions there, though. I suspect a good solution would be to check if there's an exclamation mark in the string. If not, regexp-quote and add !.*@.* – though it's not clear to me if it should do submatches, word matches, or only full matches …

@jorgenschaefer jorgenschaefer modified the milestones: v2.4, v2.5 Feb 25, 2017
@jorgenschaefer jorgenschaefer modified the milestones: v2.5, v2.6 May 28, 2017
@jorgenschaefer jorgenschaefer modified the milestones: v2.6, v2.7 Sep 29, 2017
@jorgenschaefer jorgenschaefer modified the milestones: v2.7, v2.8 Jan 28, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants