Tree sitter support for csharp mode

[theothornhill]

Adding support for tree sitter!
Some notes:

• optional feature to start with; enable using csharp-mode-enable-tree-sitter
• there are still bugs, but should be ok to use as an experimental feature
• code is moved around to separate functionality. Best to not view diff, rather look at whole file

Edit:

• indentation logic is only a backport of tree-sitter-indent until it arrives in Melpa
• It should not change default csharp-mode behavior

BTW - tried indenting a file with 2k lines with all lines set to column 0. Almost instantly with tree-sitter, 3-4 secs with cc mode. Yay!

[theothornhill]

Check in as csharp-tree-sitter.el?

Its own file? Yeah, can do that! But ci still needs that dependency, doesnt it?

[theothornhill]

AAAAAND green :)

[theothornhill]

@josteink Objections to me merging this?

[josteink]

Give me a day or so to review first, please. It's a big one 😃

[theothornhill]

Give me a day or so to review first, please. It's a big one 😃

Absolutely :)

[theothornhill]

Having some issues with getting the feature toggle correct. CC Mode is so invasive, so need to think a little about this :)

[theothornhill]

Now they are separate major modes - csharp-tree-sitter-mode and csharp-mode. The old csharp mode is now exactly the same as before, and the new one has instructions in README.org. It is meant to be experimental for now. It is a lot easier to get test cases that people actually worry about.

[josteink]

Having some issues with getting the feature toggle correct. CC Mode is so invasive, so need to think a little about this :)

I can take a look at what's here now anyway. There's always things to improve, even if there are more changes coming later :)

[theothornhill]

Great! The feature switching works now, so should be easy to switch between them at least 👍

[theothornhill]

Pr is significantly smaller now, since we can rely on tree-sitter being in MELPA now - thanks @FelipeLema!

[jcs090218]

Would it be better if csharp-tree-sitter-mode is a minor-mode instead of a major-mode? I think having two possible auto-mode-alist configuration would cause confusion.

(add-to-list 'auto-mode-alist '("\\.cs\\'" . csharp-mode))  ; this?
(add-to-list 'auto-mode-alist '("\\.cs\\'" . csharp-tree-sitter-mode))  ; or this?

Anyway, thanks for the hard work. I very appreciated this support! ;)

[theothornhill]

I see your point and am willing to think about this - however, I think we should just get it out there to see what sticks. Right now I think I didn’t add it to auto-mode, to not override default behavior. Also, I hope we can ditch cc mode altogether some time.

I’d be willing to take a look at a suggestion, if you want to add one though:)

[theothornhill]

I think that given how this no longer affects csharp-mode.el at all we are safe to merge this. It will make it easier for people to contribute, and it already seems to be a little interest around this feature. So I'm pulling the trigger :) Feel free to revert and/or scold me at any time 🤕

Fixes (or adresses) #142 #148 #182 #201 #203

[josteink]

No problem on my end.

I'm curious about future tree-sitter *BSD support, but in its current state, this PR does no harm 🙂

[theothornhill]

No problem on my end.

I'm curious about future tree-sitter *BSD support, but in its current state, this PR does no harm 🙂

Yeah I know. I think either we add instructions for how to compile everything for *BSD, or make sure emacs-tree-sitter at some point also handles that. I don't know when or how though :)

I'll also bump a new version to melpa stable