Skip to content

Allow specifying path for the common module from the outside #33

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented May 6, 2024

This enables chiptool generate --svd atsaml10d14a.svd --common-module super::common and same for gen-block

@bugadani bugadani changed the title Allow specifying common module from the outside Allow specifying path for the common module from the outside May 6, 2024
@Dirbaio
Copy link
Member

Dirbaio commented May 6, 2024

passing super::common won't work in the general case when you generate things at multiple depths in the module tree. To do it right you'd have to go through relative_path somehow.

@bugadani
Copy link
Contributor Author

bugadani commented May 6, 2024

umm that sounds way too much a hassle for this, I guess my example should have been crate::pac::common :)

The hard part is that my use case that I wanted to support here is essentially to cut-and-paste parts of the result into my project, so the module which references common doesn't have a predefined path in chiptool.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants