ADC interrupt for STM32F103 doesn't work property

[Tnze]

Current ADC implement only works on the example. Adding totally unrelated parts to the program breaks the ADC function.

• The default sample time SampleTime::CYCLES1_5 works. Set to other cause Adc::read().await hang-up forever.
• Then add line defmt::info!("convert started"); to embassy-stm32/src/adc/f1.rs file convert() function above line T::state().waker.register(.... makes it work...
• My project uses USB CDC. When start the USB task, ADC doesn't work, when remove USB stuffs the ADC works again.

, which is quite confusing. And it takes my hours to debug.

It turns out that the ADC End of Convert interrupt doesn't triggered at all. So the poll_fn wouldn't wake up once it go pending. It only works if the convert was completed before first time the poll_fn is polled.

embassy/embassy-stm32/src/adc/f1.rs

Lines 124 to 132 in 51d87c6

	poll_fn(|cx| {
	T::state().waker.register(cx.waker());
	if !T::regs().cr2().read().swstart() && T::regs().sr().read().eoc() {
	Poll::Ready(())
	} else {
	Poll::Pending
	}
	})

[Tnze]

Also, the example stm32f1/src/bin/adc.rs only works on Debug. Release doesn't work.

I think it's because of Debug runs a lot slowly, so that the ADC can finish its work before the HAL first query the eof flag.

[Tnze]

Regards @xoviat ,
I would be grateful if you could help. I'm unable to find the reason why the EOC interrupt didn't be triggered.

[Tnze]

Add this line fix this problem:

unsafe { NVIC::unmask(pac::interrupt::ADC1_2) };