Luxon Take 3: Use fromJSDate instead of fromISO for ember-cli-deploy-revision-data #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @kpfefferle . 3rd time lucky ;) Released as https://github.com/ember-cli-deploy/ember-cli-deploy-display-revisions/releases/tag/v2.1.2 |
|
@kpfefferle Well on track for that Hacktoberfest t-shirt 😛 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed & Why
I made a mistake in #41 by assuming that since
console.logwas spitting out2020-10-26T16:01:36.000Zfor timestamps provided from ember-cli-deploy-revision-data, those were ISO timestamps. It turns out that they are JS Date objects andconsole.logtransforms them into that format automatically 🤦🏻♂️Instead of trying to parse ISO if we don't have milliseconds, we should instead fall back to JS Date objects. Since this fallback was added especially for ember-cli-deploy-revision-data and its central place in the e-c-d ecosystem, we'll assume this format if we don't have milliseconds as this plugin documents.
Related issues
#41 (comment)
People
@koendehondt @achambers