add scm-data-generators and git scm generator #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghedamat
force-pushed
the
enrich-revision-data
branch
2 times, most recently
from
7040f31 to
a3aabae
Compare
|
I wonder if "data collector" would be a better name than "data generator" |
| return new Promise(function(resolve, reject) { | ||
| simpleGit(_this.path).log(function(err, log) { | ||
| var info = log.latest; | ||
| var sha = info.hash.slice(0, 7); |
There was a problem hiding this comment.
why not preserve the whole hash? Other plugins that want to shorten it can choose to do that
There was a problem hiding this comment.
this is actually unused :/ should remove it, my linter is failing me here
ghedamat
force-pushed
the
enrich-revision-data
branch
2 times, most recently
from
5a8ab1b to
72e8e86
Compare
This was referenced Mar 19, 2016
|
Looks good 👍 |
ghedamat
force-pushed
the
enrich-revision-data
branch
from
72e8e86 to
fc9e0ba
Compare
| @@ -155,6 +168,36 @@ The file containing your project's version number. Must be a JSON file with a to | |||
|
|
|||
| *Default:* `package.json` | |||
|
|
|||
| ## Scm Data Generators | |||
|
|
|||
| Scm Data generators are the strategies used to collect extra information about the revision being deployed. An scm data generator must return an object which contains properties that it deems relevant tothe revision being deployed . | |||
ghedamat
force-pushed
the
enrich-revision-data
branch
2 times, most recently
from
3e1854d to
bbf2f1d
Compare
|
@lukemelia updated |
|
LGTM @ghedamat. What's up with the circleci build? And why do we have both travis and circle on this repo? |
ghedamat
force-pushed
the
enrich-revision-data
branch
from
bbf2f1d to
6b3b9a1
Compare
|
@lukemelia fixed the circle thingy by removing it now that we use travis and added tag support to scm generator |
|
👍 Great work @ghedamat! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first step in tackling ember-cli-deploy/ember-cli-deploy#305
see
ember-cli-deploy/ember-cli-deploy-redis#56
ember-cli-deploy/ember-cli-deploy-display-revisions#8
this assumes that we're ok in keeping the approach were we "hardcode" the possible "providers" into this plugin.
TODOs: