-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[WIP] Github Gist backend #1
Conversation
apiCall (url, token) { | ||
var token = token || this.get('_token'); | ||
|
||
return new Ember.RSVP.Promise(function(resolve, reject){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use ic.ajax instead here
@alexspeller cleaned up the code. |
This is looking great, do you want me to merge now or wait for the other checklist items? |
I'd rather have to complete flow working first. I might run into stuff forcing me to refactor. |
var self = this; | ||
|
||
return this.github.find('/gists/' + id).then(function (json) { | ||
return self.deserialize(json); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use arrows instead of self = this
@alexspeller maybe we should setup Travis for this? |
The demo app is not rendering yet (don't know why) and module resolving is not working atm. |
@alexspeller I've created a |
@alexspeller two questions:
|
Do not merge
Some initial work on using the Github API for this
New pointers