Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[WIP] Github Gist backend #1

Merged
merged 11 commits into from
Mar 28, 2015
Merged

Conversation

joostdevries
Copy link
Member

Do not merge

Some initial work on using the Github API for this

  • Implement Github Oauth using Torii
  • Persist session in cookie
  • Fetch gist
  • Clean up Github code
  • Write serializer/adapter for gist <---> file
  • UI tweaks

New pointers

  • Block files whose content > 1 MB (will require additional API logic + it's insane to fiddle files that large)

apiCall (url, token) {
var token = token || this.get('_token');

return new Ember.RSVP.Promise(function(resolve, reject){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ic.ajax instead here

@joostdevries
Copy link
Member Author

@alexspeller cleaned up the code.

@alexspeller
Copy link
Member

This is looking great, do you want me to merge now or wait for the other checklist items?

@joostdevries
Copy link
Member Author

I'd rather have to complete flow working first. I might run into stuff forcing me to refactor.

var self = this;

return this.github.find('/gists/' + id).then(function (json) {
return self.deserialize(json);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use arrows instead of self = this

@joostdevries
Copy link
Member Author

@alexspeller maybe we should setup Travis for this?

@joostdevries
Copy link
Member Author

@joostdevries
Copy link
Member Author

The demo app is not rendering yet (don't know why) and module resolving is not working atm.

@joostdevries
Copy link
Member Author

@alexspeller I've created a gists branch. Maybe it's better to merge my work into that so we can both work on it?

@joostdevries
Copy link
Member Author

@alexspeller two questions:

alexspeller added a commit that referenced this pull request Mar 28, 2015
@alexspeller alexspeller merged commit 8026cc0 into ember-cli:master Mar 28, 2015
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants