Save users from trolling #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cibernox
force-pushed
the
save-users-from-trolling
branch
3 times, most recently
from
f9d83bc to
d90f493
Compare
…trolling If a user mistakenly uses `Ember.get(headers, headerName)` it will work now, but will warn the user to use `header.get(headerName)` instead.
cibernox
force-pushed
the
save-users-from-trolling
branch
from
d90f493 to
b3c1064
Compare
rwjblue
approved these changes
Nov 10, 2017
|
@kratiahuja - Do you mind releasing (I can't get to it until tomorrow or Sunday)? |
|
@rwjblue Sure, I'll do in an hour or two. I'll ping on this PR once the new version is out and go ahead bump other deps. |
|
FWIW, this is not a pressing matter for me, no rush. |
|
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #172
/cc @danmcclain @rwjblue